Design added to login page, Add report "readOnly" mode and Form navigation update

[jasalisbury]

67

Description of change

Make the login page look like the design:

• Implement welcome placard, per design
• Update tests that rely on login placard
• Give that login placard the role=dialog.

How to test

Try both logging out, and changing BYPASS_AUTH=false. Login page should look like the design.

Issue(s)

• closes Add Design to Login page #67

Checklist

• Meets issue criteria
• Code tested
• Meets accessibility standards (WCAG 2.1 Levels A, AA)
• Documentation updated
  • API methods
  • Boundary and Data Flow Diagrams
  • Architectural Decision Records written for major infrastructure decisions with the Nygard template
  • OSCAL templates completed when security controls are implemented or modified

285

Description of change

Reports are now placed in a read only mode if

• The report's status is submitted or approved
• The user viewing the report is NOT the author or a collaborator

In read only mode the user can only view the review page.

Also added a button/API call to move a report from submitted back to draft mode, allowing the author or collaborators to make edits after submitting but before approval.

How to test

1. Pull down
2. Fill out and submit an activity report
3. Note after submitting you see the submitted review page and you cannot browse to other pages of the report
4. Bring the report back to draft status
5. Submit the report again
6. As the approving manager pull up the report, note you are forced to stay on the review page, set the status to Needs Action
7. As the author pull up the report, note you can edit the report as if it had a status of draft
8. Resubmit the report and approve with the approving manager
9. Note the report cannot be edited once approved

Keeping in draft until a few of the other report PRs get merged. Still need to update API docs with the new route.

Issue(s)

• closes Prevent editing of reports not in "Draft" or "Needs Action" mode #285

Checklist

• Meets issue criteria
• Code tested
• Meets accessibility standards (WCAG 2.1 Levels A, AA)
• Documentation updated
  • API methods
  • Boundary and Data Flow Diagrams
  • Architectural Decision Records written for major infrastructure decisions with the Nygard template
  • OSCAL templates completed when security controls are implemented or modified

313

Description of change

• Any page navigation saves the form to the API
• Continue is not blocked by an invalid form
• If the page is valid on navigation that page is marked as complete
  *~ Any save with an id of "new" triggers a page reload with the saved activity report's id instead of "new"~
• Any save with an id of "new" will trigger a full page reload the next time the user navigates to a different page.
• After visiting the review page validation errors are shown in the form
• Fixed a bug where report recipients couldn't be removed

How to test

1. Pull down changes
2. Create a new report. Click "Continue" without completely filling out the first page, you should navigate to the second page
3. Visit the review page, and back to the first page. You should see required fields marked with errors
4. Completely fill out the first page. Navigate away with the side nav. The state of the first page should be "Complete"

Issue(s)

• closes Form navigation update #313

Checklist

• Meets issue criteria
• Code tested
• Meets accessibility standards (WCAG 2.1 Levels A, AA)
• Documentation updated
  • API methods
  • Boundary and Data Flow Diagrams
  • Architectural Decision Records written for major infrastructure decisions with the Nygard template
  • OSCAL templates completed when security controls are implemented or modified