Requested changes to the TTA Overview widgets - add non-grantees, combine tta hours, fix region order #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Landing Ttahub 138 al tp survey on ar landing
Ttahub 138/al fix csp for script
* Add non-grantees; layout changes * Deploy to sandbox * Include legacy reports in statistics; limit to approved reports only * Increase frontend test timeout * Add a script to connect non-grantees to activity reports for legacy data * Add a script to connect non-grantees to activity reports for legacy data * Add a script to connect non-grantees to activity reports for legacy data * Fix lint errors * Fix test * Remove non-legacy filter * Remove statement * Adjust test * Remove new test
Kw conflict
Debug intermittent rendering issue
PatricePascual-ACF
approved these changes
Jun 25, 2021
thewatermethod
added a commit
that referenced
this pull request
Nov 15, 2021
* Bump validator from 13.6.0 to 13.7.0 Bumps [validator](https://github.com/validatorjs/validator.js) from 13.6.0 to 13.7.0. - [Release notes](https://github.com/validatorjs/validator.js/releases) - [Changelog](https://github.com/validatorjs/validator.js/blob/master/CHANGELOG.md) - [Commits](validatorjs/validator.js@13.6.0...13.7.0) --- updated-dependencies: - dependency-name: validator dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * welcoming robots in certain situations * Update known vulnerabilities * trying a different approach in the config * is this how we set vars? * fix var name * test on dev since sandbox does not do what I thought * update trusworks with modal changes * need to learn how to do bash * more bash better * for christmas sake * testing complete * fix bash script var names * updated file uploader modal * updated external resource modal * move logic to circlci config * awaken robot on prod * Update .circleci/config.yml Co-authored-by: Josh Salisbury <[email protected]> * add approvedat migration * update approvedAt on approval * clean up constants, add new one * add approved and created dates to fe landing page * add approved and created date to csv download * remove console statement * fixing tests * fixed modal unit tests * updated my alert test * fixed modal tests for external resource * partial fixes for ui tests * clean up prop type * cleanup UI tests * more unit test fixes for trussworks2 * idle modal test fixes * add backend tests * fixed accessibility issue and added test coverage * add target populations to ar * add approved and created date to ar, table css fixes * fix failing ui test * fix failing tooltip test * unique id value * update known issues * fix axe * Update known vulnerabilities * fix axe again * fix axe issues again * try heading axe fix * update test for axe * update * see if remvoing display none fixes issue * hide headings * limit number of headings * added cusom accordion with heading size prop * added test for accordion * fix capitalizations while we're here * fixes based on Kryss comments * linter fixes * audit vuln Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: unknown <[email protected]> Co-authored-by: Adam Levin <[email protected]> Co-authored-by: Josh Salisbury <[email protected]> Co-authored-by: Adam Levin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Follow-up PR to the TTA overview widget. Fixes region order in the region select dropdown. Adds non-grantees to the widget and combines duration into one item. Additionally, it includes the legacy reports in statistics and limits the reports to approved ones. This PR also creates a script that allows to extract the non-grantee data from the legacy imported field.
How to test
https://tta-smarthub-dev.app.cloud.gov/activity-reports
Issue(s)
Checklists
Every PR
Production Deploy
After merge/deploy