[Issue #2515] use CodeOwners to assign reviewers and don't try to upgrade Python #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
reviewed
Jan 2, 2025
| "sammysteiner", | ||
| "acouch", | ||
| "jamesbursa", | ||
| "coilysiren", |
There was a problem hiding this comment.
Ah!!!! I didn't realize this was happening
| "analytics/pyproject.toml", | ||
| "api/pyproject.toml" | ||
| ], | ||
| "matchPackagePatterns": ["python"] |
There was a problem hiding this comment.
Given that basically nobody will know this config language offhand, can you link to the docs in the PR description please 🙏🏽
There was a problem hiding this comment.
Done, though, for this part I actually just cribbed off the existing one above (assuming it was working as intended) and took a best guess.
There was a problem hiding this comment.
I'm pretty sure i found the pattern for the postgres one on a stack overflow post, and for Kaleido just assumed it was the same despite it being a different file. It seems to have worked, but I didn't have any specific docs to point to either
coilysiren
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2515
Time to review: 2 mins
Changes proposed
Update Renovate's config to use CodeOwners to assign reviewers and ignore Python releases since we need to evaluate those releases more deeply before allowing.
Renovate Config Docs