Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2515] use CodeOwners to assign reviewers and don't try to upgrade Python #3375

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[Issue #2515] use CodeOwners to assign reviewers and don't try to upgrade Python #3375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,7 @@
"dependencies"
],
"branchPrefix": "renovate/",
"reviewers": [
"sammysteiner",
"acouch",
"jamesbursa",
"coilysiren",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah!!!! I didn't realize this was happening

"aplybeah"
],
"reviewersFromCodeOwners": true,
"rangeStrategy": "update-lockfile",
"timezone": "America/New_York",
"vulnerabilityAlerts": {
Expand Down Expand Up @@ -136,6 +130,15 @@
"analytics/poetry.lock"
],
"matchPackagePatterns": ["kaleido"]
},
{
"description": "Don't upgrade Python itself as annual releases reflect as minor version bumps",
"enabled": false,
"matchFileNames": [
"analytics/pyproject.toml",
"api/pyproject.toml"
],
"matchPackagePatterns": ["python"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that basically nobody will know this config language offhand, can you link to the docs in the PR description please 🙏🏽

Copy link
Collaborator Author

@mdragon mdragon Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, though, for this part I actually just cribbed off the existing one above (assuming it was working as intended) and took a best guess.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

valid valid

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure i found the pattern for the postgres one on a stack overflow post, and for Kaleido just assumed it was the same despite it being a different file. It seems to have worked, but I didn't have any specific docs to point to either

}
]
}