feat: create last-modified mapping #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever this package is built in CI a module `modules/frus.xqm` is added to the built XAR. This can then be used to optimize caching in hsg-shell.
line-o
force-pushed
the
feat/cacheability
branch
from
68136c0 to
0057038
Compare
line-o
added a commit
to line-o/hsg-shell
that referenced
this pull request
Jan 20, 2025
Utilizing the frus.xqm that is added with HistoryAtState/frus#343 The date in the map is not the last modified date in the database which might change frequently but the last commit date.
line-o
added a commit
to line-o/hsg-shell
that referenced
this pull request
Jan 20, 2025
Utilizing the frus.xqm that is added with HistoryAtState/frus#343 The date in the map is not the last modified date in the database which might change frequently but the last commit date.
2 tasks
|
@joewiz pointed out that the script does only return the same date for all files. This is likely due to us only checking out a single commit in CI.
|
|
@joewiz and I found a different way to obtain the last committed date $file='volumes%2Ffrus1981-88v01.xml'; \
curl -s "https://api.github.com/repos/HistoryAtState/frus/commits?path=$file&page=1&per_page=1" | \
jq ".[0] | .commit.author.date" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever this package is built in CI a module
modules/frus.xqmis added to the built XAR.This can then be used to optimize caching in hsg-shell.