improve cacheing of frus volumes and bibliographies #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Utilizing the frus.xqm that is added with HistoryAtState/frus#343 The date in the map is not the last modified date in the database which might change frequently but the last commit date.
line-o
requested review from
joewiz and
windauer
and removed request for
joewiz
line-o
commented
Jan 21, 2025
| @@ -138,28 +140,26 @@ declare variable $config:PUBLICATIONS := | |||
| "collection": $config:FRUS_VOLUMES_COL, | |||
| "document-last-modified": function($document-id) { | |||
There was a problem hiding this comment.
rewrite to use a single function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As these pages do take a significant amount of time to render it is crucial to cache them as long as possible.
With this PR applied rendered pages last-modified header will be set to the last commit date of the source file.
NOTE: needs