bring fork up to date with 2.13 release #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for localStorage * Pubcid uses local storage first
* added support to use multiple requests for SRA requests with more than 10 bids * updated unit test to test SRA dividing 100 bids into 10 requests
* addressed feedback from #3731 ticket * removed commented code from emx test spec * logging removed from spec * flip h & w values from playerSize for video requests
* Sonobi Adapter added support for UnifiedId/tdid * fixed unit test * added semi colons * removed fallback tdid on crumbs
* add page_url parameter * update test
* Add HTML5 video support param to bid requests * Use const instead of var for consistency * Update supported sizes - Default size returned changed from 0x0 to 1x1 to support PrebidServer - Now will always respect the bid sizes supported when configured Co-authored-by: Josh Becker <[email protected]> * Update maintainer contact email
* Added wrapperType and wrapperVersion parameters in ad request for TrustX Bid Adapter
Add Go2Net Adapter Alias
Privacy icon can be provided by some bidders, adding this field allows publisher to render privacy link with provided icon on it
* Synacormedia: Added video support to adapter. Added playerSize to video test page. * Synacormedia: Updated test case for IE/Edge * Synacormedia: Updates based on PR review
* Improve emoteevBidAdapter ** Squash several pending changes - Improve test coverage - Extreme programming: 100% test coverage - Document important constants - Extreme programming: document all functions - Imperative shell, functional core - Send events onBidWon and onTimeout - Report GDPR relevance and consent Code documentation uses JSDoc tags wherever possible. See the following link for general explanation of the notation used: https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler ** Test coverage - 100% Statements 110/110 - 100% Branches 55/55 - 100% Functions 28/28 - 100% Lines 99/99 ** Integration tests Tested against production endpoint with the possible combinations of these following parameters: - Browser: · Chrome Canary 75.0.3739.0 · Firefox Developer Edition 67.0b3 (64-bit) · Safari version 12.0.3 (14606.4.5) · Tor Browser 8.0.6 (based on Mozilla Firefox 60.5.1esr) - Integration page: · integrationExamples/gpt/hello_world_emoteev.html · https://jsfiddle.net/8aqotw1k/6/ Localhost test server launched with: $ npm install && gulp serve * Tentative CI fix for IE and Edge webGL test https://circleci.com/gh/prebid/Prebid.js/2052 * Tentative CI fix for IE and Edge webGL test #2 * Give up on webGL tests Has anybody an idea to make it pass? https://circleci.com/gh/prebid/Prebid.js/2056 New test coverage: - 94.5% Statements 103/109 - 98.18% Branches 54/55 - 100% Functions 28/28 - 93.88% Lines 92/98 * Avoid useless noice in diff * Remove unallowed metric pixel ON_ADAPTER_CALLED
* initial orbidder version in personal github repo * use adUnits from orbidder_example.html * replace obsolete functions * forgot to commit the test * check if bidderRequest object is available * try to fix weird safari/ie issue * ebayK: add more params * update orbidderBidAdapter.md * use spec.<function> instead of this.<function> for consistency reasons * add bidfloor parameter to params object * fix gdpr object handling
* initial changes for longform e2e testing * added old safari browsers back, test spec file, and updated test pages * add retries settings to e2e tests, lower timeout thresholds * remove commented code * additional clean-up * update browser versions for more stable e2e tests * support host param in gulp command and other updates * refactor how host param was handled * add ie11 to browsers but remove it for e2e tests * update gulp task name to e2e-test * update e2e variable
* Sovrn Analytics Adapter * unit test fix * use relative paths for imports
* update VIS.X bid adapter to support identical uids in the parameters * added wrapperType and wrapperVersion parameters in the ad request for VIS.X bid adapter * added second iteration of the response processing to ignore requested sizes in VIS.X bid adapter
* add skip to last test * change skip to describe block * updated tests to be more stable by removing prebid global calls in tests
* ReklamStore Bid Adapter ReklamStore Bid Adapter * Added unit test for user sync Added unit test for user sync * Update bid adapter Update bid adapter * Reklamstore Adapter Update Reklamstore Adapter Update
* added universal id support to bid adapter * added unit test for universal id support * added universal id support to bid adapter * added unit test for universal id support * renamed universalId to userId * removed old code from merge mistake * test for unit test
* fix ref error on yieldmo adapter * Delete yarn.lock
…pter + minor fixes (#3749) * Livewrapped bid and analytics adapter * Fixed some tests for browser compatibility * Fixed some tests for browser compatibility * Changed analytics adapter code name * Fix double quote in debug message * modified how gdpr is being passed * Added support for Publisher Common ID Module * Corrections for ttr in analytics * ANalytics updates * Auction start time stamp changed * Detect recovered ad blocked requests Make it possible to pass dynamic parameters to adapter
* Add support for bidderRequest.refererInfo in Adhese Adapter. * Apply code review suggestions
* PrebidManager Analytics: init module * PrebidManager Analytics: tests fix * PrebidManager Analytics: fix test * PrebidManager Analytics: renamed file names * PrebidManager Analytics: work on PR comments - default url, version, tests * PrebidManager Analytics: bring back ver * PrebidManager Analytics: setInterval for flush in enable analytics, fix empty config options, prebid function pageViewId * PrebidManager Analytics: disable analytics
https://prg.smartadserver.com is the standard domain for smartadserver. This update make the "bid.params.domain"-parameter optional.
* update e2e tests in README * add clarifying note * added note about Prebid.org members + browserstack
* added universal id support to bid adapter * added unit test for universal id support in bid adapter * added universal id support to bid adapter * added unit test for universal id support in bid adapter * renamed universalID to userId * removed merge mistake * fix old code in test
not sure how this empty file got placed in the root. removing
* changes for multiformat support * added new constant NATIVE_ASSETS in PubMatic adapter * removed NATIVE_ASSET_KEY reference in PubMatic adapter * removed reference of const NATIVE_ASSET_ID from PubMatic adapter * removed reference of const NATIVE_ASSET_DATA_TYPE in PubMatic adapter * using _commonNativeRequestObject in PubMatic adapter to avoid repeating code block * removed new-lines in const declaration * generating NATIVE_ASSET_REVERSE_ID from NATIVE_ASSETS * renamed NATIVE_ASSET_REVERSE_ID to NATIVE_ASSET_ID_TO_KEY_MAP * little modification in _checkParamDataType in PubMatic adapter * a minor improvement * using let instead of var * added NATIVE_ASSET_KEY_TO_ASSET_MAP and combining switch cases * lint update * removed some stale comments * using LOG_WARN_PREFIX * using const UNDEFINED * added a logWarn in catch * using arrow functions * code review changes * making adSlot parameter optional * added a test case for without adSlot config * changes to checkMediaType function * suppress warning of missing mediaTypes.banner for native and video impression * ignore fluid size, if present, in banner impression * fix for ignoring fluid size in banner impression * added relevant comments and test cases for fluid case in banner request * added sample config for multiformat adunit * commented redundant check * marking adSlot param as optional in examples * fixed some lint errors * removed commnented code * removed a trailing white space * removed a todo comment as suggested in review * deleting commented test cases
* Add new viBidAdapter * Change request schema * Min area is 1 * Send bidId * Refactor getDocumentHeight * Add getDocumentHeight test * Remove getWindowHeight * Add getOffset tests * Add getWindowParents tests * Add getTopmostReachableWindow test * Add curWindow * Add more tests * Add getIframeType tests * Rename hostile->nonfriendly * Add more params to bid request * Add getFrameElements tests * Add area tests * Add more tests * Add more tests * Add getViUserId * Add fallback to localStorage * Change bid URL * Add media-types * Remove user id * withCredentials: true * Add https * Remove getViUserId from spec * Add mergeSizes * Add useSizes param
* Add bucksense Adapter * fixed first revision for new Bucksense adapter approval https://circleci.com/gh/prebid/Prebid.js/2365? * fixed second revision for new Bucksense adapter approval from jsnellbaker #3785 * fixed third revision for new Bucksense adapter approval. #3785 * fixed 4th revision from jsnellbaker - removed console.log and using utils.logInfo(); - removed bksdebug params; pending issue: - gulp test-coverage still under 80%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information