-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI tests.yml: Deploy the retired Docker image #13806
Conversation
Review period will end on 2022-09-06 at 15:59:38 UTC. |
Review period skipped due to |
- name: Deploy the retired Docker image to GitHub Packages and Docker Hub | ||
if: github.ref == 'refs/heads/master' | ||
run: | | ||
printf 'FROM alpine\nCMD echo "Error: homebrew/ubuntu16.04:master is retired. Use homebrew/brew or homebrew/ubuntu16.04 or homebrew/ubuntu22.04:master"; exit 1\n' | | ||
docker build --tag=retired - | ||
docker tag retired "ghcr.io/homebrew/ubuntu16.04:master" | ||
docker push "ghcr.io/homebrew/ubuntu16.04:master" | ||
docker tag retired "homebrew/ubuntu16.04:master" | ||
docker push "homebrew/ubuntu16.04:master" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems weird to do this every time when it's something that only needs to be done once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can revert this PR immediately after it's merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about guarding whatever we go with to the 3.6.0 tag? Would like to have the code kept around so we have it for the next Ubuntu LTS upgrade. Alternatively, could just add it to the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems better suited for its own workflow that is done with workflow_dispatch
, but I'm not strongly opposed to this.
Tested this out. The message is never displayed in GitHub Actions: https://github.com/Bo98/brew-image-retirement-test/runs/8198518314?check_suite_focus=true I think what we would have to do is keep a Ubuntu 16.04 base (for bash etc.) and have a stub If we'd like a deprecation period, which I would encourage, I have played with that a bit. Looks like this: https://github.com/Bo98/brew-image-retirement-test/runs/8199992071?check_suite_focus=true (ignore the permission error). Could be tweaked to be less spammy but seems to work. Also appears in the summary: https://github.com/Bo98/brew-image-retirement-test/actions/runs/2997682091, which is also where GitHub puts their own deprecation messages. Code: Bo98@e364272 + a |
I like this. |
#13819 shows what we can do for a crossover deprecation period. What we do for retirement will be slightly different. I'll open a second PR for that. |
Merge this PR after merging PR Homebrew/homebrew-core#108590
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?