Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests.yml: Deploy the retired Docker image #13806

Closed

Conversation

sjackman
Copy link
Contributor

@sjackman sjackman commented Sep 5, 2022

Merge this PR after merging PR Homebrew/homebrew-core#108590


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@sjackman sjackman self-assigned this Sep 5, 2022
@BrewTestBot
Copy link
Member

Review period will end on 2022-09-06 at 15:59:38 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 5, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Sep 5, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 5, 2022
Comment on lines +191 to +199
- name: Deploy the retired Docker image to GitHub Packages and Docker Hub
if: github.ref == 'refs/heads/master'
run: |
printf 'FROM alpine\nCMD echo "Error: homebrew/ubuntu16.04:master is retired. Use homebrew/brew or homebrew/ubuntu16.04 or homebrew/ubuntu22.04:master"; exit 1\n' |
docker build --tag=retired -
docker tag retired "ghcr.io/homebrew/ubuntu16.04:master"
docker push "ghcr.io/homebrew/ubuntu16.04:master"
docker tag retired "homebrew/ubuntu16.04:master"
docker push "homebrew/ubuntu16.04:master"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems weird to do this every time when it's something that only needs to be done once.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can revert this PR immediately after it's merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about guarding whatever we go with to the 3.6.0 tag? Would like to have the code kept around so we have it for the next Ubuntu LTS upgrade. Alternatively, could just add it to the docs.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems better suited for its own workflow that is done with workflow_dispatch, but I'm not strongly opposed to this.

@Bo98
Copy link
Member

Bo98 commented Sep 6, 2022

Tested this out. The message is never displayed in GitHub Actions: https://github.com/Bo98/brew-image-retirement-test/runs/8198518314?check_suite_focus=true

I think what we would have to do is keep a Ubuntu 16.04 base (for bash etc.) and have a stub brew script that prints the message. (This can be addition to the CMD/ENTRYPOINT.)

If we'd like a deprecation period, which I would encourage, I have played with that a bit. Looks like this: https://github.com/Bo98/brew-image-retirement-test/runs/8199992071?check_suite_focus=true (ignore the permission error). Could be tweaked to be less spammy but seems to work. Also appears in the summary: https://github.com/Bo98/brew-image-retirement-test/actions/runs/2997682091, which is also where GitHub puts their own deprecation messages. Code: Bo98@e364272 + a .docker-deprecate file planted in the Docker image.

@carlocab
Copy link
Member

carlocab commented Sep 6, 2022

Also appears in the summary: https://github.com/Bo98/brew-image-retirement-test/actions/runs/2997682091, which is also where GitHub puts their own deprecation messages.

I like this.

@Bo98
Copy link
Member

Bo98 commented Sep 7, 2022

#13819 shows what we can do for a crossover deprecation period.

What we do for retirement will be slightly different. I'll open a second PR for that.

@sjackman sjackman deleted the sj/retire-ubuntu16.04-master branch September 7, 2022 16:26
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants