Add messaging for homebrew/ubuntu16.04:master image deprecation
#13819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2022-09-08 at 12:32:15 UTC. |
BrewTestBot
added
the
waiting for feedback
7 tasks
MikeMcQuaid
added
the
critical
|
Review period skipped due to |
BrewTestBot
removed
the
waiting for feedback
BrewTestBot
approved these changes
Sep 7, 2022
carlocab
approved these changes
Sep 7, 2022
It probably won't. I see messages that print to what should be stderr in CI logs all the time. |
MikeMcQuaid
approved these changes
Sep 7, 2022
What is the question? |
MikeMcQuaid
reviewed
Sep 7, 2022
| @@ -359,6 +359,18 @@ fi | |||
| ##### Now, do everything else (that may be a bit slower). | |||
| ##### | |||
|
|
|||
| # Docker image deprecation | |||
| if [[ -f "${HOMEBREW_REPOSITORY}/.docker-deprecate" ]] | |||
There was a problem hiding this comment.
How about putting this in the docker root rather than repository root?
There was a problem hiding this comment.
Will require modifying the Dockerfile, I think. Could make it an arg that gets passed that, if set, does this.
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is not a 3.6.0 blocker given it only applies on
masterpushes anyway.I've not tested if printing to stderr breaks anything in
Homebrew/test-bot. I hope not.