-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cask/artifact/abstract_uninstall: allow wildcard entries for launchctl #14123
cask/artifact/abstract_uninstall: allow wildcard entries for launchctl #14123
Conversation
Review period will end on 2022-11-10 at 02:25:11 UTC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work so far! Some style comments and I'd like to see some test coverage here.
Review period ended. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
I have made some of the suggested changes here. I'm getting stuck on writing tests for this, would love some direction/help with this. |
@bevanjkay Happy to help! Can you ask a more specific question here? |
I have added an initial test that ensures that a system command is sent to search for all running |
@bevanjkay good job getting things 💚. would still love if you can investigate or reply to remaining comments from me and CodeCov, thanks! |
Thanks again @bevanjkay! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This is an initial attempt to allow wildcard entries in Cask's
uninstall launchctl
stanza.The code takes the list of launchctl services provided in the uninstall stanza, and when it finds an
*
it will search the loaded systemlaunchctl
items to find any that match, and then pass them to the existing system for uninstalling. There may well be a more efficient/effective way to do this, however I just wanted to get the ball rolling here.This will likely require new tests to be written, I have little knowledge on unit testing so some guidance here would be great.
Homebrew/homebrew-cask-drivers#3104
Homebrew/homebrew-cask#79661