-
-
Notifications
You must be signed in to change notification settings - Fork 437
Conversation
Update & attempt to simplify uninstall
Update & attempt to simplify uninstall
@Mr-TTOT Homebrew/brew#14123 will add the ability to handle these cases. I just haven't had the time to get it finished yet. |
Thanks for the update! Is there any more info on the reason for the apparent UUIDs added to the end? Curious if it's intentional new behavior or something unexpected. Related to contributing: is there a way to run the integration tests locally before submitting a PR? And is there any other more extensive doc than the Cask Cookbook for designing the uninstall and livecheck stanzas? |
@Mr-TTOT You can check this out for |
Any updates on this? |
@iamjoeysox I will hopefully have some time tomorrow to have a look at the dependent PR. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Hey buddy, let me know if there is anything I can do to help out, this keeps causing me headaches with clients haha. Thanks again! |
@iamjoeysox I've spent some time on it today and I think it should be very close now. I've never written tests for Ruby, so it's been a learning curve |
That's awesome news! No worries, I totally understand. 😄 |
/rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you to @bevanjkay for all the hard work getting this over the line!
Update & attempt to simplify uninstall to troubleshoot #3073
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making all changes to a cask, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.