Skip to content
This repository was archived by the owner on Nov 22, 2023. It is now read-only.

Update wacom-tablet to 6.4.0-9 #3127

Merged
merged 12 commits into from
Dec 29, 2022
Merged

Update wacom-tablet to 6.4.0-9 #3127

merged 12 commits into from
Dec 29, 2022

Conversation

Mr-TTOT
Copy link
Contributor

@Mr-TTOT Mr-TTOT commented Nov 20, 2022

Update & attempt to simplify uninstall to troubleshoot #3073

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

@Mr-TTOT Mr-TTOT changed the title Update wacom-tablet to 6.4.0-8 Update wacom-tablet to 6.4.0-9 Nov 23, 2022
@bevanjkay
Copy link
Member

@Mr-TTOT Homebrew/brew#14123 will add the ability to handle these cases. I just haven't had the time to get it finished yet.

@Mr-TTOT
Copy link
Contributor Author

Mr-TTOT commented Nov 26, 2022

Thanks for the update! Is there any more info on the reason for the apparent UUIDs added to the end? Curious if it's intentional new behavior or something unexpected.

Related to contributing: is there a way to run the integration tests locally before submitting a PR? And is there any other more extensive doc than the Cask Cookbook for designing the uninstall and livecheck stanzas?

@p-linnane
Copy link
Member

@Mr-TTOT You can check this out for livecheck: https://docs.brew.sh/Brew-Livecheck

@iamjoeysox
Copy link

Any updates on this?

@bevanjkay
Copy link
Member

@iamjoeysox I will hopefully have some time tomorrow to have a look at the dependent PR.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Dec 23, 2022
@mys721tx mys721tx mentioned this pull request Dec 24, 2022
9 tasks
@iamjoeysox
Copy link

@iamjoeysox I will hopefully have some time tomorrow to have a look at the dependent PR.

Hey buddy, let me know if there is anything I can do to help out, this keeps causing me headaches with clients haha. Thanks again!

@github-actions github-actions bot removed the stale label Dec 28, 2022
@bevanjkay
Copy link
Member

bevanjkay commented Dec 28, 2022

@iamjoeysox I've spent some time on it today and I think it should be very close now. I've never written tests for Ruby, so it's been a learning curve

@iamjoeysox
Copy link

@iamjoeysox I've spent some time on it today and I think it should be very close now. I've never written tests for Ruby, so it's been a learning curve

That's awesome news! No worries, I totally understand. 😄

@bevanjkay
Copy link
Member

/rebase

@bevanjkay bevanjkay marked this pull request as ready for review December 29, 2022 21:52
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you to @bevanjkay for all the hard work getting this over the line!

@p-linnane p-linnane merged commit 2da065c into Homebrew:master Dec 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants