Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve minimum macOS version audit for casks #14297

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Improve minimum macOS version audit for casks #14297

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Library/Homebrew/cask/audit.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,7 @@ def check_livecheck_min_os
return if item.blank?

min_os = item.elements["sparkle:minimumSystemVersion"]&.text
min_os = "11" if min_os == "10.16"
return if min_os.blank?

begin
Expand All @@ -581,7 +582,8 @@ def check_livecheck_min_os

return if cask_min_os == min_os_string

add_error "Upstream defined #{min_os_string} as minimal OS version and the cask defined #{cask_min_os}"
add_error "Upstream defined #{min_os_string.to_sym.inspect} as minimal OS version " \
"and the cask defined #{cask_min_os.to_sym.inspect}"
end

sig { void }
Expand Down