Improve minimum macOS version audit for casks #14297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rylan12
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Dec 27, 2022
p-linnane
approved these changes
Dec 27, 2022
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the audit that checks the minimum macOS version in casks. Now, the audit displays symbols instead of version numbers when explaining what's wrong. Ultimately, the
depends_online uses the OS symbol instead of the number, so it's better to just list that instead of forcing the user to convert between version numbers and symbols.Also, the edge case where a cask specifies 10.16 as the minimum version has been handled. Now, 10.16 is treated as
:big_sur.For context, see Homebrew/homebrew-cask#138579