Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask/audit: improve sparkle minimum version audit #14298

Merged
merged 3 commits into from
Dec 28, 2022
Merged

cask/audit: improve sparkle minimum version audit #14298

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e11f31
cask/audit: improve sparkle minimum version audit
bevanjkay Dec 28, 2022
2788efb
Update audit.rb
bevanjkay Dec 28, 2022
c45a32e
Update Library/Homebrew/cask/audit.rb
bevanjkay Dec 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Library/Homebrew/cask/audit.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,8 +582,9 @@ def check_livecheck_min_os

return if cask_min_os == min_os_string

min_os_symbol = cask_min_os&.to_sym.inspect || "no minimal OS version"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rylan12 I think that adding the & in the first half means that min_os_symbol becomes "nil", instead of the nicer error message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch 😅

There's a fix in #14302

add_error "Upstream defined #{min_os_string.to_sym.inspect} as minimal OS version " \
"and the cask defined #{cask_min_os.to_sym.inspect}"
"and the cask defined #{min_os_symbol}"
end

sig { void }
Expand Down