Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cask/audit: improve sparkle minimum version audit #14298

Merged
merged 3 commits into from
Dec 28, 2022
Merged

cask/audit: improve sparkle minimum version audit #14298

merged 3 commits into from
Dec 28, 2022

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Dec 28, 2022 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is a continuation of #14297 - where the cask doesn't specify a minimum depends_on the audit was erroring out with a type error. This now returns an appropriate message.

Related: Homebrew/homebrew-cask#138667

@BrewTestBot
Copy link
Member

Review period will end on 2022-12-29 at 04:20:28 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 28, 2022
@bevanjkay bevanjkay requested a review from Rylan12 December 28, 2022 04:20
Rylan12
Rylan12 approved these changes Dec 28, 2022
View reviewed changes
@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Dec 28, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 28, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Rylan12 Rylan12 enabled auto-merge December 28, 2022 06:31
@Rylan12 Rylan12 merged commit de0e9b0 into Homebrew:master Dec 28, 2022
bevanjkay
bevanjkay commented Dec 29, 2022
View reviewed changes
Library/Homebrew/cask/audit.rb
@@ -582,8 +582,9 @@ def check_livecheck_min_os

return if cask_min_os == min_os_string

min_os_symbol = cask_min_os&.to_sym.inspect || "no minimal OS version"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rylan12 I think that adding the & in the first half means that min_os_symbol becomes "nil", instead of the nicer error message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch 😅

There's a fix in #14302

@p-linnane p-linnane mentioned this pull request Dec 29, 2022
Merged
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Jan 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Rylan12 Rylan12 Rylan12 approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bevanjkay @BrewTestBot @Rylan12