Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "move dev-cmd/bottle methods to extend/os" #14585

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Revert "move dev-cmd/bottle methods to extend/os" #14585

merged 2 commits into from
Feb 10, 2023
+34 −78

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Feb 10, 2023 •
edited
Loading

This broke bottle reproducibility: Homebrew/homebrew-core#122739 (comment)

Reverts #14479

CC @hyuraku @Bo98 @carlocab

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 10, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit a78006a into master Feb 10, 2023
@MikeMcQuaid MikeMcQuaid deleted the revert-14479-apply-extend/os-to-dev-cmd/bottle branch February 10, 2023 17:41
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcQuaid @BrewTestBot