geometry 2.0.0 (new formula)

[danielbayley]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[carlocab]

Suggested change

	libexec.install ["functions", "geometry.zsh"]
	pkgshare.install ["functions", "geometry.zsh"]

This seems more typical of other Zsh plugins.

[danielbayley]

@carlocab Ideally, all prompt themes should be zsh_function.installed so they can be autoloaded for promptinit, but this one doesn't work like that… @geometry-zsh

[carlocab]

Yes, I don't find pkgshare a great place either (some zsh_* location is probably better), but that's where a bunch of other formula install *.zsh plugins, so we should at least try to be consistent.

[danielbayley]

we should at least try to be consistent

Agreed, but looking at other prompt formulae, it is currently very inconsistent… Some of them use #{HOMEBREW_PREFIX}/share/ (would opt not be more appropriate here, anyway?), others #{opt_prefix}/, others [opt_]pkgshare/, and others still zsh_function.

Some have caveats, but others do not… It all seems a bit arbitrary.

For zsh prompts specifically, autoloading them from #{prefix}/share/zsh/site-functions (the zsh_function.install location, already found onFPATH) is the proper way to install a prompt theme, and should speed up zshell initial load time, as opposed to just sourceing directly in .zshrc…

[chenrui333]

looks like test is still failing for 12

[danielbayley]

looks like test is still failing for 12

@chenrui333 So strange, since that’s the version I am actually still using on my local machine, where the test passes…

The same test was passing before changing libexec to [opt_]pkgshare, as suggested by @carlocab. How could this affect expect?

[danielbayley]

@chenrui333 Passing now…?! 🤷🏻‍♂️

[carlocab]

Odd... We just have a bunch of text files. I wonder if we've broken bottle reproducibility somewhere.

❯ sha256sum *.tar.gz
348594557bfc3c624b36587813a25116a7c8c33105f31c8575dd4ef929313c1a  geometry--2.0.0.arm64_big_sur.bottle.tar.gz
480610e8e542d736504fa4d739d2eb46cb14e398824968422dcbb878721707a9  geometry--2.0.0.arm64_monterey.bottle.tar.gz
3cb5530758212e247046b03b8b0320ffcfb24b7afcca9656e792e490335ec54f  geometry--2.0.0.arm64_ventura.bottle.tar.gz
524875fa324bbd0e9046def6c3348beaf35eb2c5f3e3ed46152f04660065cd7f  geometry--2.0.0.big_sur.bottle.tar.gz
47c45998f48eb2485993834cf79861c6f7b02fb380765351b7d374a3568d5c8a  geometry--2.0.0.monterey.bottle.tar.gz
788cbccf9fc8997ef005203f9df33567e8880618df892fae6209cf7272cc3b3c  geometry--2.0.0.ventura.bottle.tar.gz
77d688cd33571e3f3fcdd38e1b49fb2ed6188445a2ac9db527d6093b694528d3  geometry--2.0.0.x86_64_linux.bottle.tar.gz

CC @Homebrew/brew

Here's some output from diffoscope: out.html.gz

[Bo98]

Yep, looks broken by Homebrew/brew#14479. require should be at the end I think.

Looks like the same thing might have happened to the other cmd changes too.

[carlocab]

Rebased to pull in the bottle fix. Can merge once CI is complete.

[BrewTestBot]

@carlocab has triggered a merge.

[p-linnane]

I'm not sure this should have been added to homebrew-core, as it appears to be unmaintained. Livecheck is returning 2.2.0, so I opened a PR to bump this. Turns out the last commit was July 2021, and the latest release (2.0.0) was August 2019.

[carlocab]

This is just a shell plugin, so the need for maintenance is quite low. I've seen widely used shell completion scripts that haven't changed for much, much longer than that.

[p-linnane]

Are we ok with changing to strategy :github_latest for livecheck and calling it a day then?

[carlocab]

We can probably bump this to 2.2.0 actually. It looks like only major releases get registered as GitHub releases, but later tags seem fine for general use.

[p-linnane]

@carlocab Would you mind approving my linked PR so we can get it merged?