rubocop: Clean up Style/BlockDelimiters excludes and autofix offenses
#14920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review period will end on 2023-03-08 at 23:00:45 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
requested changes
Mar 8, 2023
There was a problem hiding this comment.
Thanks for the PR @issyl0! Let's change specs rather than the non-spec code here, if we want consistency.
| @@ -152,10 +152,10 @@ def find_launchctl_with_wildcard(search) | |||
| regex = Regexp.escape(search).gsub("\\*", ".*") | |||
| system_command!("/bin/launchctl", args: ["list"]) | |||
| .stdout.lines.drop(1) # skip stdout column headers | |||
| .map do |line| | |||
| .map { |line| | |||
There was a problem hiding this comment.
Sorry, really don't agree with this change. Would rather we enforced specs to use this format than change non-spec code for this.
There was a problem hiding this comment.
So you want EnforcedStyle: line_count_based (the default) everywhere (so for multi-line blocks they're always do ... end?
issyl0
force-pushed
the
rubocop-block-delimiters
branch
from
e3fc20d to
b753677
Compare
BrewTestBot
removed
the
waiting for feedback
|
Review period ended. |
BrewTestBot
approved these changes
Mar 8, 2023
issyl0
force-pushed
the
rubocop-block-delimiters
branch
from
b753677 to
1be614e
Compare
- The defaults of using "do ... end" for multi-line blocks everywhere is good, better than switching everything to braces everywhere.
issyl0
force-pushed
the
rubocop-block-delimiters
branch
from
1be614e to
3a83b54
Compare
MikeMcQuaid
approved these changes
Mar 9, 2023
|
Nice, thanks @issyl0! |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Excludewithrubocop#14685, maybe?!EnforcedStyle: braces_for_chainingconfig makes the most sense. It preserves a lot of the RSpec syntax we're used to inexpect {}blocks that are chained to other things - quite a lot of them - and uses normal block syntax for non-chained methods (as the name suggests - I probably didn't need to write that down).