Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: Remove comment about RSpec from Style/BlockDelimiters config #14945

Merged
merged 1 commit into from
Mar 11, 2023
Merged

rubocop: Remove comment about RSpec from Style/BlockDelimiters config #14945

merged 1 commit into from
Mar 11, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Mar 11, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@issyl0
rubocop: Remove comment about RSpec from Style/BlockDelimiters config
b00203f 
- We got rid of the RSpec-related excludes in PR 14920. I should have
  got rid of this comment too.
@BrewTestBot
Copy link
Member

Review period will end on 2023-03-14 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 11, 2023
@MikeMcQuaid MikeMcQuaid added critical Critical change which should be shipped as soon as possible. and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Mar 11, 2023
@MikeMcQuaid MikeMcQuaid enabled auto-merge March 11, 2023 08:03
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

MikeMcQuaid
MikeMcQuaid approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@MikeMcQuaid MikeMcQuaid merged commit 921ad96 into Homebrew:master Mar 11, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@issyl0 @BrewTestBot @MikeMcQuaid