-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sorbet: Run brew typecheck --update --suggest-typed
on schedule in CI
#14921
Conversation
- No idea if this works, let's experiment. - Suggested in Homebrew#14893 (comment).
Review period will end on 2023-03-08 at 23:09:33 UTC. |
.github/workflows/sorbet.yml
Outdated
if ! git diff --stat --exit-code "Library/Homebrew/sorbet" | ||
then | ||
git add "Library/Homebrew/sorbet" | ||
git commit -m "sorbet: Update RBI files." \ | ||
-m "Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow." | ||
|
||
git add "**/*.rb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be any more specific? I'd hate to accidentally include files we don't want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh, perhaps limit to Library/Homebrew
and maybe exclude vendor
or something?
Another random thought: does this only upgrade and never downgrade sigils?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The vendor
directory is already excluded since Spoom uses Sorbet's config file.
It appears that it only upgrades and never downgrades, yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, thanks @issyl0! One comment.
.github/workflows/sorbet.yml
Outdated
if ! git diff --stat --exit-code "Library/Homebrew/sorbet" | ||
then | ||
git add "Library/Homebrew/sorbet" | ||
git commit -m "sorbet: Update RBI files." \ | ||
-m "Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow." | ||
|
||
git add "**/*.rb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh, perhaps limit to Library/Homebrew
and maybe exclude vendor
or something?
Another random thought: does this only upgrade and never downgrade sigils?
Review period ended. |
Awesome, thanks @issyl0! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?typed: true
#14893 (comment).