Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet: Run brew typecheck --update --suggest-typed on schedule in CI #14921

Merged
merged 3 commits into from
Mar 9, 2023
Merged

sorbet: Run brew typecheck --update --suggest-typed on schedule in CI #14921

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7053036
sorbet: Run `brew typecheck --update --suggest-typed` on schedule in CI
issyl0 Mar 7, 2023
9c9f6b3
sorbet: Oops, missed a `*` for `**/*.rb` path wildcards
issyl0 Mar 7, 2023
20fe371
sorbet: More specific `git add` for `--suggest-typed` CI autobumps
issyl0 Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/sorbet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,17 @@ jobs:
git checkout --no-track -B "${BRANCH}" origin/master
fi

brew typecheck --update
brew typecheck --update --suggest-typed
if ! git diff --stat --exit-code "Library/Homebrew/sorbet"
then
git add "Library/Homebrew/sorbet"
git commit -m "sorbet: Update RBI files." \
-m "Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow."

git add "**/*.rb"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be any more specific? I'd hate to accidentally include files we don't want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, perhaps limit to Library/Homebrew and maybe exclude vendor or something?

Another random thought: does this only upgrade and never downgrade sigils?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vendor directory is already excluded since Spoom uses Sorbet's config file.

It appears that it only upgrades and never downgrades, yes.

git commit -m "sorbet: Autobump sigils via Spoom" \
-m "Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow."

echo "committed=true" >> $GITHUB_OUTPUT
PULL_REQUEST_STATE="$(gh pr view --json=state | jq -r ".state")"
if [[ "${PULL_REQUEST_STATE}" != "OPEN" ]]
Expand Down