formula_cellar_checks: more granular mismatched_binary_allowlist #16944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for providing more granular glob patterns via the mismatched_binary_allowlist.json rather than an all-or-nothing option. This allows catching any unwanted binaries in new releases.
The glob patterns are assumed to be relative to the formula's prefix. Patterns are matched using fnmatch with flags for:
File::FNM_DOTMATCH
to allow matching all files with**/*
File::FNM_EXTGLOB
to behave likeDir.glob
for{a,b}
File::FNM_PATHNAME
to allow restricting*
across directoriesThe original file format of
["<formula>"]
should behave similar to{"<formula>": "**/*"}
.Also some changes to add type signature.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?For an example, see
homebrew-core
PR: Homebrew/homebrew-core#167024