mismatched_binary_allowlist: use more granular globs #167024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
automerge-skip
7 tasks
|
Probably going to create separate PRs to test (as I don't think modifying only audit list will trigger this check). Or modify corresponding formulae in this PR with some minor changes. |
cho-m
added
CI-skip-dependents
cho-m
force-pushed
the
mismatched_binary_allowlist-granular-entries
branch
2 times, most recently
from
9805c1b to
95f25cf
Compare
cho-m
commented
Mar 25, 2024
Comment on lines
4
to
5
| "faust": "share/faust/android/app/lib/libsndfile/lib/*/libsndfile.so", | ||
| "lima": "share/lima/lima-guestagent.Linux-*", | ||
| "faust": "share/faust/android/app/lib/libsndfile/*/libsndfile.so", | ||
| "lima": "share/lima/lima-guestagent.Linux-a*", |
There was a problem hiding this comment.
At least seems to work as intended when using incomplete glob, e.g. https://github.com/Homebrew/homebrew-core/actions/runs/8413974251/job/23037083115?pr=167024
faust
* Binaries built for a non-native architecture were installed into faust's prefix.
The offending files are:
/home/linuxbrew/.linuxbrew/Cellar/faust/2.70.3/share/faust/android/app/lib/libsndfile/lib/arm64-v8a/libsndfile.so (arm64)
/home/linuxbrew/.linuxbrew/Cellar/faust/2.70.3/share/faust/android/app/lib/libsndfile/lib/armeabi-v7a/libsndfile.so (arm)
lima
* Binaries built for a non-native architecture were installed into lima's prefix.
The offending files are:
/home/linuxbrew/.linuxbrew/Cellar/lima/0.21.0/share/lima/lima-guestagent.Linux-riscv64 (dunno)
Error: 1 problem in 1 formula detected.
95f25cf to
6992a9f
Compare
Signed-off-by: Michael Cho <[email protected]>
cho-m
force-pushed
the
mismatched_binary_allowlist-granular-entries
branch
from
6992a9f to
f3bb258
Compare
cho-m
added
ready to merge
chenrui333
approved these changes
Mar 26, 2024
|
make sense 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Working on
brewfeature in Homebrew/brew#16944Probably need to rework
balena-clias there are some unwanted libs there.