audit: more *_predicate nudging/tweaks #3293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DomT4
commented
Oct 9, 2017
Library/Homebrew/dev-cmd/audit.rb
Outdated
| problem "Use `assert_predicate <path_to_file>, :executable?` instead of `#{Regexp.last_match(1)}`" | ||
| end | ||
|
|
||
| if line =~ /(assert !File\.executable\?|assert !\(.*\)\.executable\?)/ |
There was a problem hiding this comment.
We might not need this line really, because why would you logically check something was not executable? Thoughts welcome.
5 tasks
|
Given #3313 I think this should probably be integrated in there instead. |
|
Given it seems to be working fine I'm not sure why it needs to be made fancier and block on that happening. |
|
Ok then. Once #3313 goes in, though, future changes will need to be to the Rubocop. |
MikeMcQuaid
approved these changes
Oct 17, 2017
|
Thanks for merging! I was happy either way. At some point I'm going to have to sit down & wrap my head around the Rubocop format for everything, but I'll take being able to put that off for a little longer 🙈. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @ilovezfs.
Homebrew/homebrew-core#19213 (comment)