Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use assert_predicate (11) #19213

Merged
merged 38 commits into from
Oct 9, 2017
Merged

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Oct 9, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

CC @DomT4 a few stragglers.

@ilovezfs ilovezfs force-pushed the assert_predicate-11 branch from fc19294 to d5caa6d Compare October 9, 2017 09:59
@ilovezfs ilovezfs merged commit 1f899e0 into Homebrew:master Oct 9, 2017
@DomT4
Copy link
Contributor

DomT4 commented Oct 9, 2017

Nice. Thanks for catching these 🙇

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Oct 9, 2017

@DomT4 a couple cases that the audit doesn't flag:

assert !(testpath/"a").exist?

and

assert (HOMEBREW_PREFIX/"bin/npm").executable?

@DomT4
Copy link
Contributor

DomT4 commented Oct 9, 2017

assert !(testpath/"a").exist?

To be honest this syntax is so gross I presumed nobody would even think of using it. I presumed incorrectly 🙈.

assert (HOMEBREW_PREFIX/"bin/npm").executable?

Yeah, assert_predicate supports :executable? so we could police that too.

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants