Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set RuboCop maximum to current maximum. #3295

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Set RuboCop maximum to current maximum. #3295

merged 1 commit into from
Oct 12, 2017

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Oct 9, 2017 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

MikeMcQuaid
MikeMcQuaid reviewed Oct 9, 2017
View reviewed changes
Library/.rubocop.yml Outdated
@@ -63,26 +63,29 @@ Metrics/AbcSize:
Max: 250

Metrics/BlockLength:
Max: 1250
Enabled: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep these all enabled but make the maximum based on Homebrew/homebrew-core too.

@reitermarkus reitermarkus merged commit 04801a2 into Homebrew:master Oct 12, 2017
@reitermarkus reitermarkus deleted the code-style branch October 12, 2017 17:55
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reitermarkus @MikeMcQuaid