Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set RuboCop maximum to current maximum. #3295

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Set RuboCop maximum to current maximum. #3295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Library/.rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,26 +63,26 @@ Metrics/AbcSize:
Max: 250

Metrics/BlockLength:
Max: 1250
Max: 144

Metrics/ClassLength:
Max: 1500
Max: 589

Metrics/CyclomaticComplexity:
Max: 75

Metrics/LineLength:
Max: 400
Max: 324

Metrics/MethodLength:
Max: 250
Max: 222

Metrics/ModuleLength:
CountComments: false
Exclude:
- '**/bin/**/*'
- '**/cmd/**/*'
- '**/lib/**/*'
Max: 367

Metrics/ParameterLists:
CountKeywordArgs: false

Metrics/PerceivedComplexity:
Max: 100
Expand Down
0 Library/.auditcops.yml → Library/.rubocop_audit.yml
View file
Open in desktop
File renamed without changes.
14 changes: 10 additions & 4 deletions Library/Homebrew/.rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,20 @@ Lint/NestedMethodDefinition:
Lint/ParenthesesAsGroupedExpression:
Enabled: true

Metrics/BlockLength:
Max: 1250

Metrics/BlockNesting:
Max: 5

Metrics/ModuleLength:
Max: 360
Metrics/ClassLength:
Max: 1226

Metrics/LineLength:
Max: 244

Metrics/ParameterLists:
CountKeywordArgs: false
Metrics/MethodLength:
Max: 195

# we won't change backward compatible method names
Naming/MethodName:
Expand Down
2 changes: 1 addition & 1 deletion Library/Homebrew/cmd/style.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def check_style_impl(files, output_type, options = {})
args << "--config" << HOMEBREW_LIBRARY_PATH/".rubocop.yml"
args << HOMEBREW_LIBRARY_PATH
else
args << "--config" << HOMEBREW_LIBRARY/".auditcops.yml"
args << "--config" << HOMEBREW_LIBRARY/".rubocop_audit.yml"
args += files
end

Expand Down
4 changes: 2 additions & 2 deletions Library/Homebrew/test/cmd/style_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
around(:each) do |example|
begin
FileUtils.ln_s HOMEBREW_LIBRARY_PATH, HOMEBREW_LIBRARY/"Homebrew"
FileUtils.ln_s HOMEBREW_LIBRARY_PATH.parent/".rubocop.yml", HOMEBREW_LIBRARY/".auditcops.yml"
FileUtils.ln_s HOMEBREW_LIBRARY_PATH.parent/".rubocop.yml", HOMEBREW_LIBRARY/".rubocop_audit.yml"

example.run
ensure
FileUtils.rm_f HOMEBREW_LIBRARY/"Homebrew"
FileUtils.rm_f HOMEBREW_LIBRARY/".auditcops.yml"
FileUtils.rm_f HOMEBREW_LIBRARY/".rubocop_audit.yml"
end
end

Expand Down