-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum OS to Yosemite #7698
Conversation
Aside: if Misty is the one raising the minimum OS version, you know there's got to be a good reason. 😆 |
Note to self: clean up all |
Looks good. Will existing users get the updated Portable Ruby however? We want to make sure they do. One concern: this could mean that bumping the minimum OS becomes Sorbet's decision and not ours. If Sorbet suddenly drops 10.10-10.14 tomorrow say, are we fine with staying on the older version of Sorbet? |
If it is possible to deprecate in a way that Might end up being a special case for |
Last question (sorry): we use system Ruby on Catalina, which is built for |
I think that'd be ideal, and give us a clean way to gradually clean things up on our end too.
It does, but it won't be fetched in this context. I believe the reason they provide separate versions is to satisfy Rubygems, which fetches gems precisely matching Rubygems should transparently fetch whichever is the appropriate version. That means it will work on Linux too.
They won't. At the current time this will only affect users running dev commands, most likely dev commands invoking Sorbet, but providing an upgrade mechanism would be useful.
I think we can reevaluate if this becomes onerous. Right now I'm happy with this because their support schedule conveniently lines up with ours. If they suddenly drop all but the latest OS, that's obviously going to be a deal-breaker for us and we can make different decisions at that time. |
Ok, cool. I asked because the |
63f31d2
to
f4be636
Compare
Oh, it already is. Just seen the other PR. 😪 |
Done in #7716 |
For release notes https://formulae.brew.sh/analytics/os-version/30d/ will be useful. |
@mistydemeo once built from Homebrew/homebrew-portable-ruby#101 and it is merged: this is good to 🚢. |
f4be636
to
f4ff5a2
Compare
Updated, and published the new rubies for Mac and Linux; I will be merging this once CI finishes. |
* Update documentation according to Homebrew/brew#7698 * adobe-dng-converter: remove Mavericks support * amethyst: remove Mavericks support * appcleaner: remove Mavericks support * araxis-merge: remove Mavericks support * bettertouchtool: remove Mavericks support * cocktail: remove Mavericks support * coconutbattery: remove Mavericks support * coteditor: remove Mavericks support * daisydisk: remove Mavericks support * deeper: remove Mavericks support * eme: remove Mavericks support * evernote: remove Mavericks support * feishu: remove Mavericks support * geekbench: remove Mavericks support * hammerspoon: remove Mavericks support * interarchy: remove Mavericks support * ipartition: remove Mavericks support * istumbler: remove Mavericks support * itrash: remove Mavericks support * itsycal: remove Mavericks support * itunes-producer: remove Mavericks support * jitouch: remove Mavericks support * lark: remove Mavericks support * launchbar: remove Mavericks support * maintenance: remove Mavericks support * monolingual: remove Mavericks support * omnifocus: remove Mavericks support * omnipresence: remove Mavericks support * onyx: remove Mavericks support * plug: remove Mavericks support * poedit: remove Mavericks support * programmer-dvorak: remove Mavericks support * qdslrdashboard: remove Mavericks support * superduper: remove Mavericks support * thorn-writing: remove Mavericks support * time-out: remove Mavericks support * tinderbox: remove Mavericks support * x2goclient: remove Mavericks support * xlink-kai: remove Mavericks support
brew style
with your changes locally?brew tests
with your changes locally?This bumps the minimum OS version from Mavericks to Yosemite. Mavericks was already officially on life support, and wasn't receiving official support.
This is in support of #7675, Vidushee's Sorbet branch. Sorbet is very slow and error-prone to build, so it's not practical to install except using binary packages. They provide binary packages going back to Darwin 14 - e.g., macOS 10.10. In order to install that, we'll need our vendored Ruby to be built for at least that macOS version. Right now, since Homebrew runs on macOS going back to 10.9, we build our vendored Ruby for that version and it's unable to use any of the Sorbet binary packages.
I've built a new portable Ruby 2.6.3 for Yosemite and uploaded it to Bintray. I'll publish it and push it to GitHub when this branch is approved.