Skip to content
This repository was archived by the owner on May 2, 2024. It is now read-only.

Remove support for Mavericks #9184

Merged
merged 7 commits into from
Jun 10, 2020
Merged

Remove support for Mavericks #9184

merged 7 commits into from
Jun 10, 2020

Conversation

claui
Copy link
Contributor

@claui claui commented Jun 10, 2020

With Homebrew/brew#7698, Homebrew no longer runs on Mavericks.

In preparation, Homebrew/brew#7716 has been merged, which removes support for the :mavericks symbol.

This causes brew cask install and brew cask uninstall to fail with the following error message if cask-versions is tapped:

Error: Cask 'brave-browser-nightly' definition is invalid: invalid 'depends_on macos' value: ">= :mavericks"

This PR fixes the issue by removing all references to :mavericks.


Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

After making all changes to a cask, verify:

  • brew cask audit --download {{cask_file}} is error-free. Fails for one of the casks (403 error for brave-browser-dev) but that’s unrelated to this PR.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • There are no open pull requests for the same update.
  • The submission is for a stable version or documented exception.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.

@vitorgalvao vitorgalvao merged commit f5a1f2d into Homebrew:master Jun 10, 2020
@claui claui deleted the remove-mavericks branch June 12, 2020 07:46
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants