CPU: add ability to check for Rosetta #7995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
add_rosetta_test
branch
from
bc41b39 to
9a74223
Compare
9 tasks
|
I think it would make sense to move the Linux-specific code to instead be in the generic OS case (Library/Homebrew/hardware.rb) and override on macOS only. |
mistydemeo
force-pushed
the
add_rosetta_test
branch
from
9a74223 to
9dc001b
Compare
|
Good call, done |
mistydemeo
force-pushed
the
add_rosetta_test
branch
from
9dc001b to
f6a5c84
Compare
Keno
reviewed
Jul 13, 2020
sjackman
suggested changes
Jul 13, 2020
sjackman
reviewed
Jul 13, 2020
sjackman
reviewed
Jul 13, 2020
sjackman
reviewed
Jul 13, 2020
sjackman
reviewed
Jul 13, 2020
mistydemeo
force-pushed
the
add_rosetta_test
branch
from
f6a5c84 to
bb0a39e
Compare
|
Simplified the patch slightly with a macOS-only ARM64 helper method. In the future we'll likely be able to go without that if we can check for Rosetta directly instead of indirectly. |
sjackman
approved these changes
Jul 14, 2020
|
Wouldn't checking for https://developer.apple.com/documentation/apple_silicon/about_the_rosetta_translation_environment |
|
When we last checked, |
MikeMcQuaid
reviewed
Sep 1, 2020
When running within an Intel terminal, `uname -m` and friends return Intel-based values for compatibility. An Intel shell will also prefer to launch Intel slices of programs unless the program is ARM-only. It's an open question how Homebrew should manage running in Intel mode. Should it continue to behave as though the Mac is Intel-based, like it does now? Should it recognize it's ARM-based? Either way, it's useful for us to be able to tell whether the Mac is running under Rosetta or whether it's a real Intel Mac.
MikeMcQuaid
force-pushed
the
add_rosetta_test
branch
from
65b248f to
74d3f0b
Compare
|
@mistydemeo Thanks for this! |
ticky
added a commit
to buildkite/agent
that referenced
this pull request
Sep 9, 2020
Following on from #1237, with new discoveries! Turns out that in many cases, Apple Silicon Macs will in fact run Bash in amd64 mode, which in turn means the reported architecture is amd64, even though it's an Apple Silicon Mac. Homebrew has worked around this in Homebrew/brew#7995, and we more or less follow their lead here. This makes it so that we _always_ show our little notice on Apple Silicon Macs, whether their shell is in amd64 or arm64 mode.
|
btw, seems that it works now: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally?When running within an Intel terminal,
uname -mand friends return Intel-based values for compatibility. An Intel shell will also prefer to launch Intel slices of programs unless the program is ARM-only.It's an open question how Homebrew should manage running in Intel mode. Should it continue to behave as though the Mac is Intel-based, like it does now? Should it recognize it's ARM-based? Either way, it's useful for us to be able to tell whether the Mac is running under Rosetta or whether it's a real Intel Mac.