Fetch amd64 binaries on Apple Silicon Macs #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upcoming macOS computers will use the arm64 architecture (see https://developer.apple.com/documentation/xcode/building_a_universal_macos_binary). On such machines, our install script will currently fall through to attempting to fetch a darwin-arm binary, which does not exist. This future version of macOS allows arm64 Macs to run amd64 binaries through an emulation layer called Rosetta 2, and thus darwin-amd64 is the most appropriate binary type for these machines until golang supports native darwin-arm64. This updates our install script to special-case the arm64 architecture when the platform is darwin, emit a message to the user, and proceed more or less as expected.
|
Confirmed that this updated install script behaves correctly on an Apple Silicon Mac, and that the |
ticky
added a commit
that referenced
this pull request
Sep 9, 2020
Following on from #1237, with new discoveries! Turns out that in many cases, Apple Silicon Macs will in fact run Bash in amd64 mode, which in turn means the reported architecture is amd64, even though it's an Apple Silicon Mac. Homebrew has worked around this in Homebrew/brew#7995, and we more or less follow their lead here. This makes it so that we _always_ show our little notice on Apple Silicon Macs, whether their shell is in amd64 or arm64 mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcoming macOS computers will use the
arm64architecture. On such machines, our install script will currently fall through to attempting to fetch adarwin-armbinary, which does not exist. This future version of macOS allowsarm64Macs to runamd64binaries through an emulation layer called Rosetta 2, and thusdarwin-amd64is the most appropriate binary type for these machines until golang supports nativedarwin-arm64(see golang/go#38485).This updates our install script to special-case the arm64 architecture when the platform is darwin, emit a message to the user, and proceed more or less as expected.