Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix deprecation date check #8533

Merged
merged 1 commit into from
Aug 31, 2020
Merged

style: fix deprecation date check #8533

merged 1 commit into from
Aug 31, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Aug 29, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Follow up to #8512
Blocking Homebrew/homebrew-core#60336 (and, consequently, the release of 2.5.0)

#8512 exposed a bug in rubocop that checked the first argument to disable! or deprecate! and assumed it was date:. When adding because: arguments to disable!, rubocop failed when trying to parse a reason as a date.

Running brew style on the following fails before this but succeeds after this PR:

deprecate! because: "is broken"

@Rylan12 Rylan12 mentioned this pull request Aug 29, 2020
6 tasks
@MikeMcQuaid MikeMcQuaid merged commit 854a139 into Homebrew:master Aug 31, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @Rylan12!

@Rylan12 Rylan12 deleted the deprecate-date-issue branch August 31, 2020 12:37
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 14, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants