Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecate reason #60336

Merged
merged 35 commits into from
Aug 31, 2020
Merged

Add deprecate reason #60336

merged 35 commits into from
Aug 31, 2020

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Aug 29, 2020

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Add because: argument to deprecate! in formulae.

Supplement to #60321

CC: @MikeMcQuaid

@Rylan12 Rylan12 added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Aug 29, 2020
@BrewTestBot BrewTestBot added the formula deprecated Formula deprecated label Aug 29, 2020
@Rylan12
Copy link
Member Author

Rylan12 commented Aug 31, 2020

@MikeMcQuaid now that the brew PR fixing the issue has been merged this should be good to go. I've rebased and it now passes the style checks.

@MikeMcQuaid MikeMcQuaid merged commit f5d5509 into Homebrew:master Aug 31, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @Rylan12!

@Rylan12 Rylan12 deleted the add-deprecate-reason branch August 31, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. formula deprecated Formula deprecated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants