-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contexts: convert to on_system
blocks
#137662
Conversation
end | ||
end | ||
|
||
depends_on macos: ">= :catalina" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@p-linnane @miccal The depends_on
statements on some of these are going to be unnecessary, except for passing the audit that compares the depends_on
with the required version from sparkle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are using the combination of :or_older
on the first block and the depends_on
to prevent older OS's that don't have a version from throwing errors and breaking regeneration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this specific cask, because the livecheck uses :sparkle
the on_{system}
block has to have a depends_on macos:
that matches the minimum version in sparkle. Otherwise brew audit
fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misunderstood, but I get it now. That makes complete sense. Thanks!
Downgrading to match the livecheck broke Contexts for me - it flashes for a second and exits when started. $ brew uninstall contexts
$ cd $(dirname $(brew edit --print-path contexts))
$ git checkout a367607a6e -- contexts.rb
$ brew install contexts fixed it. (FYI:
) |
@etiennepellegrini It looks like upstream is providing a manual link to |
#137512