Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contexts: convert to on_system blocks #137662

Merged
merged 2 commits into from
Dec 14, 2022
Merged

contexts: convert to on_system blocks #137662

merged 2 commits into from
Dec 14, 2022

Conversation

bevanjkay
Copy link
Member

end
end

depends_on macos: ">= :catalina"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p-linnane @miccal The depends_on statements on some of these are going to be unnecessary, except for passing the audit that compares the depends_on with the required version from sparkle.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are using the combination of :or_older on the first block and the depends_on to prevent older OS's that don't have a version from throwing errors and breaking regeneration.

Copy link
Member Author

@bevanjkay bevanjkay Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this specific cask, because the livecheck uses :sparkle the on_{system} block has to have a depends_on macos: that matches the minimum version in sparkle. Otherwise brew audit fails.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood, but I get it now. That makes complete sense. Thanks!

@p-linnane p-linnane merged commit adb42b3 into Homebrew:master Dec 14, 2022
@etiennepellegrini
Copy link

Downgrading to match the livecheck broke Contexts for me - it flashes for a second and exits when started.

$ brew uninstall contexts
$ cd $(dirname $(brew edit --print-path contexts))
$ git checkout a367607a6e -- contexts.rb
$ brew install contexts

fixed it.

(FYI:

OS: macOS 12.6.1 21G217 x86_64
Host: MacBookPro16,1
Kernel: 21.6.0
Shell: bash 5.2.15
CPU: Intel i9-9980HK (16) @ 2.40GHz
GPU: Intel UHD Graphics 630, AMD Radeon Pro 5500M
Memory: 24336MiB / 65536MiB

)

@bevanjkay
Copy link
Member Author

@etiennepellegrini It looks like upstream is providing a manual link to 3.9.0, but their Sparkle updating mechanism may be broken at the moment.
https://contexts.co/whats-new/

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants