Convert if MacOS.version blocks to on_system blocks

[p-linnane]

Description of issue

This is a tracking issue to monitor the progress of converting all if MacOS.version blocks into the new on_system blocks. We have better coverage with brew readall using these new blocks.

• amethyst amethyst: convert to on_system blocks #137487
• apparency apparency: convert to on_system blocks #137516
• appcleaner appcleaner: convert to on_system blocks #137517
• appgate-sdp-client appgate-sdp-client: convert to on_system blocks #137518
• araxis-merge araxis-merge: convert to on_system blocks #137536
• artisan artisan: remove MacOS.version conditional #137537
• bartender bartender: remove MacOS.version conditional #137538
• bbedit Update bbedit from 14.6.1 to 14.6.1 #137539
• birdfont birdfont: convert to on_system blocks #137625
• boxcryptor boxcryptor: convert to on_system blocks #137626
• calibre calibre: convert to on_system blocks #137627
• cave-story cave-story: convert to on_system blocks #137628
• cd-to cd-to: convert to on_system blocks #137629
• choosy choosy: convert to on_system blocks #137630
• clean-me clean-me: convert to on_system blocks #137631
• cockatrice cockatrice: convert to on_system blocks #137632
• cocktail cocktail: convert to on_system blocks #137661
• contexts contexts: convert to on_system blocks #137662
• controllermate controllermate: convert to on_system blocks, discontinue #137803
• copyq copyq: convert to on_system blocks #137804
• coteditor coteditor: convert to on_system blocks #137805
• couchbase-server-enterprise couchbase-server-enterprise: convert to on_system blocks #137807
• dash dash: convert to on_system blocks #137808
• datweatherdoe datweatherdoe: convert to on_system blocks #137809
• day-o day-o: convert to on_system blocks #137810
• deeper deeper: convert to on_system blocks #137811
• diskmaker-x diskmaker-x: convert to on_system blocks #137812
• drawpile drawpile: convert to on_system blocks #137813
• duet duet: convert to on_system blocks #137515
• evernote evernote: convert to on_system blocks #138309
• f-bar f-bar: convert to on_system blocks #138310
• far2l far2l: convert to on_system blocks #138312
• flrig flrig: convert to on_system blocks #138311
• fluor fluor: convert to on_system blocks #138313
• freac freac: convert to on_system blocks #138314
• free-gpgmail free-gpgmail: convert to on_system blocks #138315
• geekbench geekbench: convert to on_system blocks #138578
• gobdokumente gobdokumente: convert to on_system blocks #138579
• hammerspoon hammerspoon: convert to on_system blocks #138580
• horos horos: convert to on_system blocks #138581
• idefrag idefrag: convert to on_system blocks #138582
• inkstitch inkstitch: convert to on_system blocks #138583
• ipartition ipartition: convert to on_system blocks #138584
• ipsecuritas ipsecuritas: convert to on_system blocks #138585
• isubtitle isubtitle: convert to on_system blocks #138586
• isyncr isyncr: convert to on_system blocks #138587
• iterm2 iterm2: convert to on_system blocks #138307
• itsycal Update itsycal from 0.13.3 to 0.13.4 #138034
• jedit-omega jedit-omega: convert to on_system blocks #138588
• jitouch jitouch: convert to on_system blocks #138589
• karabiner-elements karabiner-elements: convert to on_system blocks #138596
• klayout klayout: convert to on_system blocks #138590
• launchcontrol launchcontrol: convert to on_system blocks #137514
• lingon-x lingon-x: convert to on_system blocks #138618
• linkliar linkliar: convert to on_system blocks #138597
• liteicon liteicon: convert to on_system blocks #138598
• macpilot macpilot: convert to on_system blocks #138599
• maintenance maintenance: convert to on_system blocks #138600
• max max: convert to on_system blocks #138601
• microsoft-auto-update microsoft-auto-update: convert to on_system blocks #138602
• microsoft-excel microsoft-excel: convert to on_system blocks #138603
• microsoft-outlook microsoft-outlook: convert to on_system blocks #138604
• microsoft-powerpoint microsoft-powerpoint: conver to on_system blocks #138605
• microsoft-word microsoft-word: convert to on_system blocks #138606
• mkvtoolnix mkvtoolnix: convert to on_system blocks #138607
• monitorcontrol monitorcontrol: convert to on_system blocks #138619
• monolingual monolingual: convert to on_system blocks #138608
• mounty mounty: convert to on_system blocks #138609
• mysqlworkbench mysqlworkbench: convert to on_system blocks #138610
• natron natron: convert to on_system blocks #138611
• ncar-ncl ncar-ncl: convert to on_system blocks #138612
• nextcloud nextcloud: convert to on_system blocks #138613
• omnidisksweeper omnidisksweeper: convert to on_system blocks #137610
• omnifocus Update omnifocus from 3.14.2 to 3.14.3 #138124
• omnigraffle omnigraffle: convert to on_system blocks #138614
• omnioutliner omnioutliner: convert to on_system blocks #138615
• omniplan omniplan: convert to on_system blocks #138616
• omnipresence omnipresence: convert to on_system blocks #138617
• onyx onyx: convert to on_system blocks #137513
• openemu openemu: convert to on_system blocks #137543
• openttd openttd: convert to on_system blocks #137544
• orion orion: convert to on_system blocks #137490
• playonmac playonmac: convert to on_system blocks #137949
• powerphotos Update powerphotos from 1.9.12 to 2.1.2 #138030
• prismlauncher prismlauncher: convert to on_system blocks #138031
• proxifier proxifier: convert to on_system blocks #138032
• qbittorrent qbittorrent: convert to on_system blocks #137664
• reaper reaper: convert to on_system blocks #137663
• saoimageds9
• secretive
• sf-symbols
• silentknight
• simply-fortran
• sip
• sitesucker-pro
• sourcetree
• spideroakone
• studiolinkstandalone
• subsurface
• suspicious-package suspicious-package: convert to on_system blocks #137611
• teamspeak-client
• teamviewer teamviewer: convert to on_system blocks #137814
• touch-bar-simulator touch-bar-simulator: convert to on_system blocks #138308
• tripmode
• virtualhereserver
• visit
• vitamin-r
• vpn-enabler
• x2goclient

[Rylan12]

Thanks, everyone, for helping out with this!

I'll have a PR in homebrew/brew soon to enforce the on_system blocks

[bevanjkay]

@Rylan12 There's a few more in our other Homebrew-cask-* repos that might need attention, there's a couple of complicated ones in the drivers and versions repos.

[Rylan12]

I'm going to push forward, for now, to allow HOMEBREW_INSTALL_FROM_API to move forward (API installs aren't available for those repos right now, anyway) but I'll make sure to add a todo to hit all of these.

It looks like Homebrew/cask-drivers has 64 violations and Homebrew/cask-versions has 18.

[Rylan12]

Hmm, on second thought it might actually take more time to get the audit to be main-tap-specific so I might just start running through these. not sure yet

[bevanjkay]

@Rylan12 We can hit these next, especially if it's blocking the API project.

EDIT: I've opened PRs to update all the ones in versions.