Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iterm2: convert to on_system blocks #138307

Merged
merged 5 commits into from
Dec 22, 2022
Merged

Conversation

viking1304
Copy link
Contributor

@viking1304 viking1304 commented Dec 22, 2022

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@viking1304 viking1304 closed this Dec 22, 2022
@viking1304 viking1304 deleted the patch-1 branch December 22, 2022 09:23
@viking1304 viking1304 restored the patch-1 branch December 22, 2022 09:34
@viking1304 viking1304 reopened this Dec 22, 2022
@viking1304
Copy link
Contributor Author

@bevanjkay Thanks! I will use the same live-check approach as you did here next time.

bevanjkay
bevanjkay previously approved these changes Dec 22, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Publish failed.

@bevanjkay
Copy link
Member

/rebase

@bevanjkay bevanjkay merged commit 9997850 into Homebrew:master Dec 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants