Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touch-bar-simulator: convert to on_system blocks #138308

Closed

Conversation

viking1304
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making all changes to a cask, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@viking1304 viking1304 changed the title Touch bar simulator cask touch-bar-simulator: convert to on_system blocks Dec 22, 2022
@bevanjkay
Copy link
Member

@viking1304 Thanks! This one needs to keep the url in the different blocks because the formatting is different on the pre-mojave version.

@viking1304
Copy link
Contributor Author

@viking1304 Thanks! This one needs to keep the url in the different blocks because the formatting is different on the pre-mojave version.

Oooops! Now I see the difference in the URL. Thank you very much for pointing that out.

@bevanjkay
Copy link
Member

@viking1304 We've been adding the livecheck skip blocks where necessary, to make sure brew bump and brew livecheck wouldn't return incorrect versions when on older hardware. Sometimes an actual livecheck block can be used, but not often.

@viking1304
Copy link
Contributor Author

@viking1304 We've been adding the livecheck skip blocks where necessary, to make sure brew bump and brew livecheck wouldn't return incorrect versions when on older hardware. Sometimes an actual livecheck block can be used, but not often.

Make sense. Thanks for the explanation.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants