Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aleph-one: remove #142862

Merged
merged 1 commit into from
Mar 10, 2023
Merged

aleph-one: remove #142862

merged 1 commit into from
Mar 10, 2023

Conversation

p-linnane
Copy link
Member

This has been having certificate errors for an extended period of time.

30 days: n/a
90 days: 6 (#4618)
365 days: 22 (#5088)

@BrewTestBot BrewTestBot added marked for removal/rejection missing zap Cask is missing a zap stanza, please add one. labels Mar 10, 2023
@miccal miccal merged commit 8b2dc8d into Homebrew:master Mar 10, 2023
@p-linnane p-linnane deleted the aleph-one-remove branch March 11, 2023 00:19
@Amorymeltzer
Copy link
Contributor

@p-linnane Sorry for my not knowing, but what does "certificate errors" mean in this context?


I can open a separate issue to discuss it if preferred (cc @miccal) but I'd strongly urge reverting this if there's something moderately transient or repairable. It's part of a set of casks (marathon, marathon2, marathon-infinity) all from the same place and repo, are they having the same issue? Indeed, having any of those without aleph-one would be weird given the nature of the game/engine. I brought this up a few years ago in #88604; most of that rationale holds up, with the major difference being the project has moved to a more regular release cadence.

@p-linnane
Copy link
Member Author

@Amorymeltzer Those other casks are also having the same issue, but I didn't get around to removing them. Basically the certificate chain of the homepage is incomplete. See here. This is causing livecheck to fail.

I am open to reverting this if you'd like to open a PR and reach out to upstream about their certificate. They can use https://whatsmychaincert.com to generate a correct certificate chain.

@Amorymeltzer
Copy link
Contributor

Thanks for that. I hadn't realized there was an issue: all four are in my (brief) .brew_livecheck_watchlist and I haven't run into any problems with livchecking them on my end.

The livecheck was changed most recently in afdf3c0 to get around the GitHub issues, am I correct that those got worked out on GitHub's end? I might have my press releases mixed up.

@p-linnane
Copy link
Member Author

No, that was a permanent change on GitHub's end. If you want to open the PR to restore aleph-one I can write a new set of livechecks for those 4 casks using an alternative method of checking GitHub.

Amorymeltzer added a commit to Amorymeltzer/homebrew-cask that referenced this pull request Mar 11, 2023
@Amorymeltzer
Copy link
Contributor

Amorymeltzer commented Mar 11, 2023

Thanks @p-linnane, I appreciate it. If that works for you it works for me! #142900. I do wonder why I wasn't seeing the same issues, I assume I've trusted it in the past or something. I've passed your note along to their contact.

p-linnane pushed a commit that referenced this pull request Mar 11, 2023
@Hopper262
Copy link

Certificate chain errors at alephone.lhowon.org have now been fixed. Thanks @p-linnane for the info, and @Amorymeltzer for bringing this to my attention!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
marked for removal/rejection missing zap Cask is missing a zap stanza, please add one. outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants