(re)add marathon2 and marathon-infinity casks #88604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both were removed in analytics purges, but they are being re added to match/parallel the marathon and aleph-one casks. *marathon2: Removed in Homebrew#63338 (cc482d5) *marathon-infinity: Removed in Homebrew#72428 (3d28779)
Amorymeltzer
added a commit
to Amorymeltzer/homebrew-cask
that referenced
this pull request
Sep 12, 2020
Was erroneously given the description of alephone in Homebrew#87436 (4002df8); this matches the descriptions given to M2:D and M:I in Homebrew#88604
10 tasks
BrewTestBot
pushed a commit
that referenced
this pull request
Sep 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew cask audit --download {{cask_file}}is error-free.brew cask style --fix {{cask_file}}reports no offenses.Additionally, if adding a new cask:
brew cask audit --new-cask {{cask_file}}worked successfully.brew cask install {{cask_file}}worked successfully.brew cask uninstall {{cask_file}}worked successfully.Both were removed in analytics purges, but I propose to re-add them to match/parallel the
marathonandaleph-onecasks.*marathon2: Removed in #63338 (cc482d5)
*marathon-infinity: Removed in #72428 (3d28779)
It's a little bit of a weird case, as while it is an active project with several alpha releases over the years, it was just officially updated for the first time in 5 years. All four casks are from the same repo (https://github.com/Aleph-One-Marathon/alephone), but that repo appear to meet the [https://github.com/Homebrew/homebrew-cask/blob/master/doc/faq/rejected_casks.md popularity recommendations]. I'm obviously not privy to the stats when they were purged, but I do think it makes sense to have these two for completion. Obviously happy to discuss (cc @vitorgalvao) if views differ, although I think this aligns with #63053 (comment) and #63053 (comment).