Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update livechecks for GitHub API usage #146730

Merged
merged 51 commits into from
May 8, 2023

Conversation

SMillerDev
Copy link
Member

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --new-cask <cask> worked successfully.
  • brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@SMillerDev
Copy link
Member Author

@razvanazamfirei razvanazamfirei force-pushed the chore/livecheck/gh_latest_api branch from 3188b07 to 6a1b805 Compare May 8, 2023 16:34
@razvanazamfirei
Copy link
Contributor

Ran brew style --fix. Hopefully it will get rid of the syntax failure.

@razvanazamfirei razvanazamfirei force-pushed the chore/livecheck/gh_latest_api branch from fe6e78b to 0584135 Compare May 8, 2023 20:57
@samford samford force-pushed the chore/livecheck/gh_latest_api branch from 0584135 to 8daab5f Compare May 8, 2023 21:05
@samford
Copy link
Member

samford commented May 8, 2023

I took care of appium (#146747), brook (#146749), and ricochet (#146754) in separate PRs, since they required additional changes.

Razvan beat me to rebasing this (dropping the commits for brook and ricochet) but I had to rebase it again to drop the appium commit. I'm currently doing a test run to make sure this takes care of all the existing breakages at this point.

Edit: The test run was good, so this can be merged when ready.

@razvanazamfirei
Copy link
Contributor

I'm just happy to be in y'all's company!

Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in Homebrew/homebrew-core#130233 (review), I'll create follow-up PRs to update the regexes to use ^/$ (like we do with Git regexes), so we can get these fixes merged in the interim time.

@p-linnane p-linnane merged commit 6e5a25e into Homebrew:master May 8, 2023
@p-linnane p-linnane added the livecheck Issues or PRs related to livecheck label May 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge-skip livecheck Issues or PRs related to livecheck outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants