-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update livechecks for GitHub API usage #146730
chore: update livechecks for GitHub API usage #146730
Conversation
See also Homebrew/homebrew-core#130233 and Homebrew/brew#15270 |
3188b07
to
6a1b805
Compare
Ran |
fe6e78b
to
0584135
Compare
0584135
to
8daab5f
Compare
I took care of Razvan beat me to rebasing this (dropping the commits for Edit: The test run was good, so this can be merged when ready. |
I'm just happy to be in y'all's company! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in Homebrew/homebrew-core#130233 (review), I'll create follow-up PRs to update the regexes to use ^
/$
(like we do with Git
regexes), so we can get these fixes merged in the interim time.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --new-cask <cask>
worked successfully.brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.