Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update GitHub Latest livechecks for GitHub API usage #130233

Merged
merged 62 commits into from
May 9, 2023

Conversation

SMillerDev
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Accompanies Homebrew/brew#15270

@SMillerDev SMillerDev changed the title Chore/livecheck/gh latest api chore: update GitHub Latest livechecks for GitHub API usage May 5, 2023
@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label May 5, 2023
@SMillerDev SMillerDev force-pushed the chore/livecheck/gh_latest_api branch 3 times, most recently from c970cd2 to 968c08a Compare May 8, 2023 15:48
@SMillerDev SMillerDev marked this pull request as ready for review May 8, 2023 15:48
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the brew style issues (i.e., some of these regexes are unnecessarily using the %r{} syntax now).

The modified regexes should also be updated to use ^ at the start and $ at the end. The existing regexes effectively anchored the start of the tag with /tag/ and the end with ["' >] and those can now be replaced with ^/$ (in keeping with Git strategy regexes).

Once that's done, I'll push a few commits that address the livecheck blocks that this doesn't fix.

@SMillerDev SMillerDev force-pushed the chore/livecheck/gh_latest_api branch from 968c08a to 86d5c30 Compare May 8, 2023 17:42
@samford
Copy link
Member

samford commented May 8, 2023

The modified regexes should also be updated to use ^ at the start and $ at the end. The existing regexes effectively anchored the start of the tag with /tag/ and the end with ["' >] and those can now be replaced with ^/$ (in keeping with Git strategy regexes).

So we don't hold this up, I'll take care of this in a follow-up PR since it wasn't addressed here.

We'll need someone else to approve this, since I pushed the most recent commit.

@p-linnane p-linnane added this pull request to the merge queue May 9, 2023
@p-linnane p-linnane added the livecheck Issues or PRs related to livecheck label May 9, 2023
Merged via the queue into Homebrew:master with commit 743a56d May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants