-
-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update GitHub Latest livechecks for GitHub API usage #130233
chore: update GitHub Latest livechecks for GitHub API usage #130233
Conversation
c970cd2
to
968c08a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the brew style
issues (i.e., some of these regexes are unnecessarily using the %r{}
syntax now).
The modified regexes should also be updated to use ^
at the start and $
at the end. The existing regexes effectively anchored the start of the tag with /tag/
and the end with ["' >]
and those can now be replaced with ^
/$
(in keeping with Git
strategy regexes).
Once that's done, I'll push a few commits that address the livecheck
blocks that this doesn't fix.
968c08a
to
86d5c30
Compare
So we don't hold this up, I'll take care of this in a follow-up PR since it wasn't addressed here. We'll need someone else to approve this, since I pushed the most recent commit. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Accompanies Homebrew/brew#15270