Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsync 1.27.0 (new formula) onnxruntime 1.17.3 #169254

Closed
wants to merge 2 commits into from
Closed

nsync 1.27.0 (new formula) onnxruntime 1.17.3 #169254

wants to merge 2 commits into from

Conversation

chenrui333
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Apr 17, 2024
@chenrui333 chenrui333 force-pushed the bump-onnxruntime-1.17.3 branch from 962189f to 82129f1 Compare April 17, 2024 01:13
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Apr 17, 2024
@chenrui333
Copy link
Member Author

needs nsync, https://github.com/google/nsync

@chenrui333 chenrui333 added build failure CI fails while building the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Apr 17, 2024
@chenrui333 chenrui333 mentioned this pull request Apr 17, 2024
Merged
@chenrui333 chenrui333 force-pushed the bump-onnxruntime-1.17.3 branch from 82129f1 to 27678fe Compare April 17, 2024 14:27
@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Apr 17, 2024
@chenrui333 chenrui333 changed the title onnxruntime 1.17.3 nsync 1.27.0 (new formula) onnxruntime 1.17.3 Apr 17, 2024
@chenrui333 chenrui333 removed the build failure CI fails while building the software label Apr 17, 2024
@chenrui333 chenrui333 force-pushed the bump-onnxruntime-1.17.3 branch from 27678fe to 0219caf Compare April 17, 2024 14:30
@carlocab
Copy link
Member

carlocab commented Apr 17, 2024 •
edited
Loading

This patch might help: https://gitlab.archlinux.org/archlinux/packaging/packages/nsync/-/blob/c7526aec9773890ce798b029efef48921e004124/nsync-export.patch

Not sure why it hasn't been upstreamed.

@chenrui333
Copy link
Member Author

somehow it built out fine in my local. also gonna upstream that patch as well.

@chenrui333 chenrui333 mentioned this pull request Apr 17, 2024
Merged
@chenrui333
nsync 1.27.0 (new formula)
929aadc 
Signed-off-by: Rui Chen <[email protected]>

autobump: add nsync

Signed-off-by: Rui Chen <[email protected]>

nsync: update build

Signed-off-by: Rui Chen <[email protected]>

nsync: add cmake build patch

Signed-off-by: Rui Chen <[email protected]>
@chenrui333
onnxruntime 1.17.3
e084886 
autobump: add onnxruntime

Signed-off-by: Rui Chen <[email protected]>

onnxruntime: update build and test

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 force-pushed the bump-onnxruntime-1.17.3 branch from 0219caf to e084886 Compare April 17, 2024 17:34
@carlocab
Copy link
Member

somehow it built out fine in my local. also gonna upstream that patch as well.

It's not for nsync, the patch is needed for onnxruntime to find nsync.

It fixed a build failure but revealed another one

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Apr 20, 2024
@chenrui333 chenrui333 removed the stale No recent activity label Apr 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Apr 23, 2024
@github-actions github-actions bot closed this Apr 24, 2024
@miccal miccal deleted the bump-onnxruntime-1.17.3 branch April 24, 2024 05:48
@github-actions github-actions bot added the outdated PR was locked due to age label May 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age stale No recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @carlocab