Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformio 4.3.4 #55152

Closed
wants to merge 4 commits into from
Closed

platformio 4.3.4 #55152

wants to merge 4 commits into from

Conversation

ivankravets
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @ivankravets. The version bump sounds packed full of features! 👍

One thing that would be good here is to make sure that the brew test platformio command is testing a feature of the command-line tool and asserting some output, rather than just that it prints --help. Something like the following would be good to add, please:

  test do
    output = shell_output("#{bin}/platformio account show 2>&1", 1).chomp
    assert_match "Error: You are not authorized! Please log in to PIO Account.", output
  end

@ivankravets
Copy link
Contributor Author

@issyl0 thanks for the idea! I updated PR and added real tests :)

@issyl0
Copy link
Member

issyl0 commented May 23, 2020

Those tests look good, thanks! Could you please squash your commits into one named platformio 4.3.4, then this will be mergeable once it passes CI.

@ivankravets
Copy link
Contributor Author

Sorry, done in #55158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants