Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platformio 4.3.4 #55158

Closed
wants to merge 1 commit into from
Closed

platformio 4.3.4 #55158

wants to merge 1 commit into from

Conversation

ivankravets
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@ivankravets ivankravets mentioned this pull request May 23, 2020
5 tasks
@issyl0
Copy link
Member

issyl0 commented May 23, 2020

I'm rerunning the checks. I don't think they're keeping up properly. 😅

@ivankravets
Copy link
Contributor Author

Sorry, I'm a newbie in Ruby and use it like monkey 🐵

@issyl0
Copy link
Member

issyl0 commented May 23, 2020

I can push some commits to fix it if you like?

@ivankravets
Copy link
Contributor Author

Yes, please!

@issyl0
Copy link
Member

issyl0 commented May 23, 2020

Hmm, the first platform list test returned nothing for me locally, so I removed it. The second one listing boards still works tho so I've kept that. 👍 The relevant checks (brew style etc.) pass locally for me, and I squashed the commits, so hopefully that should be it! Thanks for your patience here!

@ivankravets
Copy link
Contributor Author

Oh, sorry! it should be platformio platform search. I did a mistake. The platformio platform list returns installed dev-platforms. In any case, we can leave with 1 test.

P.S: Amazing support! Thank you so much!

@BrewTestBot
Copy link
Member

:shipit: @issyl0 has triggered a merge.

@issyl0
Copy link
Member

issyl0 commented May 23, 2020

All done! Homebrew users can now download PlatformIO 4.3.4. 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants