rust 1.48 #66285

carlocab · 2020-12-05T11:05:47Z

Have you followed the guidelines for contributing?
Have you checked that there aren't other open pull requests for the same formula update/change?
Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Picks up from #65286.

Fixes #63202 (hopefully).

10.14

Done?	Formula	CI failure	Comment
✅	cargo-instruments	`install -s`	SHA256 mismatch (cmyr/cargo-instruments#27, #66872)
✅	deno	`install -s`	#66482
✅	findomain	`install -s`	SHA256 mismatch (Findomain/Findomain#121)
✅	ktmpl	`test`	jimmycuadra/ktmpl#5, fixed in #66914
	root	`install -s`	connection failure
✅	silicon	`install -s`	SHA256 mismatch, waiting for upstream response
✅	simgrid	`install -s`	bad build script

10.15

Done?	Formula	CI failure	Comment
✅	findomain	`install -s`	SHA256 mismatch (Findomain/Findomain#121)
	ktmpl	`test`	htps://github.com/jimmycuadra/ktmpl/issues/5, fixed in #66914
	root	`install -s`	connection failure
✅	silicon	`install -s`	SHA256 mismatch, waiting for upstream response
✅	simgrid	`install -s`	bad build script

11.0

All install --build-from-source except for asuka (test), ktmpl (test), root (both - !)

Done?	Formula	CI failure	Comment
	asuka	`test`	`pty` allocation?, #66450, #65000
✅	cargo-instruments	`install -s`	SHA256 mismatch (cmyr/cargo-instruments#27, #66872)
✅	deno	`install -s`	#66482
	echoprint-codegen	`install -s`	#65000
✅	findomain	`install -s`	SHA256 mismatch (Findomain/Findomain#121)
✅	ktmpl	`test`	jimmycuadra/ktmpl#5, fixed in #66914
	root	`install -s`, `test`	connection failure?
✅	silicon	`install -s`	SHA256 mismatch, waiting for upstream response
✅	simgrid	`install -s`	bad build script
	visp	`install -s`	#65000

All three SHA256 mismatches have been reported upstream. Links visible down the thread.

carlocab · 2020-12-11T11:59:21Z

10.14

Error: 7 failed steps!
brew install --build-from-source cargo-instruments
brew install --build-from-source deno
brew install --build-from-source findomain
brew test --retry --verbose ktmpl
brew install --build-from-source root
brew install --build-from-source silicon
brew install --build-from-source simgrid

Update:

Error: 5 failed steps!
brew test --retry --verbose ktmpl
brew install --build-from-source pike
brew audit cargo-instruments --online --git --skip-style
brew audit findomain --online --git --skip-style
brew audit silicon --online --git --skip-style

carlocab · 2020-12-11T12:34:34Z

Bizarrely, there is no sha256 mismatch error for cargo-instruments on 10.15:

Error: 5 failed steps!
brew install --build-from-source findomain
brew test --retry --verbose ktmpl
brew install --build-from-source root
brew install --build-from-source silicon
brew install --build-from-source simgrid

Update:

Error: 6 failed steps!
4940
brew install --build-from-source deno
brew test --retry --verbose ktmpl
brew install --build-from-source pike
brew audit cargo-instruments --online --git --skip-style
brew audit findomain --online --git --skip-style
brew audit silicon --online --git --skip-style

carlocab · 2020-12-11T16:04:14Z

I've diagnosed the simgrid build failure, and have found a local workaround. Upstream report here: https://framagit.org/simgrid/simgrid/-/issues/59

See also linked issues above for cargo-instruments, findomain, and silicon.

Linked issue below for ktmpl.

carlocab · 2020-12-11T16:05:15Z

11.0:

Error: 12 failed steps!
brew test --retry --verbose asuka
brew test --retry --verbose asuka
brew install --build-from-source cargo-instruments
brew install --build-from-source deno
brew install --build-from-source echoprint-codegen
brew install --build-from-source findomain
brew test --retry --verbose ktmpl
brew install --build-from-source root
brew test --retry --verbose root
brew install --build-from-source silicon
brew install --build-from-source simgrid
brew install --build-from-source visp

Not sure why there's even a brew test root there when it didn't build. The other CI nodes didn't seem to bother. (Unless they somehow failed at building from source but succeeded at testing?)

echoprint-codegen and visp are known failures, and have yet to be bottled for Big Sur: #65000

Update:

Error: 10 failed steps!
brew test --retry --verbose asuka
brew test --retry --verbose asuka
brew install --build-from-source deno
brew install --build-from-source echoprint-codegen
brew test --retry --verbose ktmpl
brew install --build-from-source pike
brew install --build-from-source visp
brew audit cargo-instruments --online --git --skip-style
brew audit findomain --online --git --skip-style
brew audit silicon --online --git --skip-style

carlocab · 2020-12-11T17:05:40Z

This is the root failure:

==> brew install --build-from-source root
==> FAILED
==> Downloading https://root.cern.ch/download/root_v6.22.04.source.tar.gz
curl: (22) The requested URL returned error: 404 Not Found
Error: Failed to download resource "root"
Download failed: https://root.cern.ch/download/root_v6.22.04.source.tar.gz

Not sure why CI keeps failing to download these tarballs. I can fetch them locally just fine.

Note that root depends on rust via:

root -> graphviz -> librsvg (build)-> rust

I feel like this is a distant enough connection not to be concerned about, though I could be wrong here.

carlocab · 2020-12-11T17:40:02Z

I tested asuka locally. It seems to be trying to open a tty, which doesn't work on Big Sur? (Cf. #66311)

Verbose Test Output

Error: asuka: failed
An exception occurred within a child process:
  Test::Unit::AssertionFailedError: </# Project Gemini/> was expected to be =~
<"stty rows 80 cols 43\r\n" +
"env LC_CTYPE=en_US.UTF-8 LANG=en_US.UTF-8 TERM=xterm /usr/local/Cellar/asuka/0.8.1/bin/asuka\r\n" +
"clear:echotc: no such capability: cl\r\n" +
"This is the Z Shell configuration function for new users,\r\n" +
"zsh-newuser-install.\r\n" +
"You are seeing this message because you have no zsh startup files\r\n" +
"(the files .zshenv, .zprofile, .zshrc, .zlogin in the directory\r\n" +
"~).  This function can help you with a few settings that should\r\n" +
"make your use of the shell easier.\r\n" +
"\r\n" +
"You can:\r\n" +
"\r\n" +
"(q)  Quit and do nothing.  The function will be run again next time.\r\n" +
"\r\n" +
"(0)  Exit, creating the file ~/.zshrc containing just a comment.\r\n" +
"     That will prevent this function being run again.\r\n" +
"\r\n" +
"(1)  Continue to the main menu.\r\n" +
"\r\n" +
"--- Type one of the keys in parentheses --- \r\n" +
"Aborting.\r\n" +
"The function will be run again next time.  To prevent this, execute:\r\n" +
"  touch ~/.zshrc\r\n" +
"%                                                                              \r \r\rcarlocab@hermes ~ % \e[?2004htty rows 80 cols 43\e[?2004l\r\r\n" +
"tty: extra operand 'rows'\r\n" +
"Try 'tty --help' for more information.\r\n" +
"%                                                                              \r \r\rcarlocab@hermes ~ % \e[?2004henv LC_CTYPE=en_US.UTF-8 LANG=en_US.UTF-8 TERM=xterm /us\r<UTF-8 LANG=en_US.UTF-8 TERM=xterm /usr                                       \r<UTF-8 LANG=en_US.UTF-8 TERM=xterm /usr/local/Cellar/asuka/0.8.1/bin/asuka\e[?2004l\r\r\n" +
"\e[?1049h\e[1;24r\e(B\e[m\e[4l\e[?7h\e[?1h\e=\e[?1000h\e[39;49m\e[?25l\e[?1002h\e[39;49m\e[34m\e[44m\e[H\e[2J\e[30m\e[47m┌──────────────────────────────┤ \e[31m\e[47mAsuka Browser\e[30m\e[47m ├───────────────────────────────┐\e[2;1H│ ┌──────────────────────────────────────────────────────────────────────────┐ │\e[3;1H│ │\e[37m\e[40mWelcome to Asuka Gemini browser!         \e[30m\e[47m\e[33X\e[78G│ │\e[4;1H│ │\e[74X\e[78G│ │\e[5;1H│ │  Press g to visit an URL\e[49X\e[78G│ │\e[6;1H│ │  Press b to go to the previous URL\e[39X\e[78G│ │\e[7;1H│ │  Press B to show bookmarks\e[47X\e[78G│ │\e[8;1H│ │  Press a to add current URL to bookmarks\e[33X\e[78G│ │\e[9;1H│ │  Press q to exit\e[57X\e[78G│ │\e[10;1H│ │\e[74X\e[78G│ │\e[11;1H│ │\e[74X\e[78G│ │\e[12;1H│ │\e[74X\e[78G│ │\e[13;1H│ │\e[74X\e[78G│ │\e[14;1H│ │\e[74X\e[78G│ │\e[15;1H│ │\e[74X\e[78G│ │\e[16;1H│ │\e[74X\e[78G│ │\e[17;1H│ │\e[74X\e[78G│ │\e[18;1H│ │\e[74X\e[78G│ │\e[19;1H│ │\e[74X\e[78G│ │\e[20;1H│ │\e[74X\e[78G│ │\e[21;1H│ └──────────────────────────────────────────────────────────────────────────┘ │\e[22;1H│\e[78X\e[80G│\e[23;1H│            <Back (b)> <Go To URL (g)> <Bookmarks (B)> <Quit (q)>             │\e[24;1H└──────────────────────────────────────────────────────────────────────────────\e[?7l┘\e[?7h\e[1;47H\e[39;49m\e(B\e[m\e[34m\e[44m\e[H\e[2J\e[30m\e[47m┌──────────────────────────────┤ \e[31m\e[47mAsuka Browser\e[30m\e[47m ├───────────────────────────────┐\e[2;1H│ ┌──────────────────────────────────────────────────────────────────────────┐ │\e[3;1H│ │\e[37m\e[44mWelcome to Asuka Gemini browser!         \e[30m\e[47m\e[33X\e[78G│ │\e[4;1H│ │\e[74X\e[78G│ │\e[5;1H│ │  Press g to visit an URL\e[49X\e[78G│ │\e[6;1H│ │  Press b to go to the previous URL\e[39X\e">.
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/gems/2.6.0/gems/test-unit-3.2.9/lib/test/unit/assertions.rb:55:in `block in assert_block'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/gems/2.6.0/gems/test-unit-3.2.9/lib/test/unit/assertions.rb:1631:in `_wrap_assertion'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/gems/2.6.0/gems/test-unit-3.2.9/lib/test/unit/assertions.rb:53:in `assert_block'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/gems/2.6.0/gems/test-unit-3.2.9/lib/test/unit/assertions.rb:543:in `block in assert_match'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/gems/2.6.0/gems/test-unit-3.2.9/lib/test/unit/assertions.rb:1636:in `_wrap_assertion'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/gems/2.6.0/gems/test-unit-3.2.9/lib/test/unit/assertions.rb:533:in `assert_match'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/asuka.rb:46:in `block in <class:Asuka>'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1871:in `block (3 levels) in run_test'
/usr/local/Homebrew/Library/Homebrew/utils.rb:504:in `with_env'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1870:in `block (2 levels) in run_test'
/usr/local/Homebrew/Library/Homebrew/formula.rb:904:in `with_logging'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1869:in `block in run_test'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:63:in `block in run'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:63:in `chdir'
/usr/local/Homebrew/Library/Homebrew/mktemp.rb:63:in `run'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2116:in `mktemp'
/usr/local/Homebrew/Library/Homebrew/formula.rb:1863:in `run_test'
/usr/local/Homebrew/Library/Homebrew/test.rb:43:in `block in <main>'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/2.6.0/timeout.rb:93:in `block in timeout'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/2.6.0/timeout.rb:33:in `block in catch'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/2.6.0/timeout.rb:33:in `catch'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/2.6.0/timeout.rb:33:in `catch'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.6.3_2/lib/ruby/2.6.0/timeout.rb:108:in `timeout'
/usr/local/Homebrew/Library/Homebrew/test.rb:42:in `<main>'

carlocab · 2020-12-14T14:12:28Z

@fxcoudert A single CI run for this PR takes about two days to complete. Given this, I was wondering what your thoughts were on my rebasing this against master to resolve conflicts and just to fix the remaining issues in separate PRs.

I've investigated all of the CI failures (and fixed about half of them). The remaining are:

Formula	CI failure	Status
~~silicon~~	~~SHA256 mismatch~~	~~Waiting for upstream response~~ (Aloxaf/silicon#141)
root	Connection failure, unable to fetch source	Cannot reproduce locally
~~ktmpl~~	~~test failure~~	~~jimmycuadra/ktmpl#5, #66914~~
asuka	test failure (11.0)	#65000, #66450
echoprint-codegen	build failure (11.0)	#65000
visp	build failure (11.0)	#65000
pike	missing dependency	`6b892c2`, fix confirmed locally. cf. #66555

fxcoudert · 2020-12-14T14:34:36Z

@carlocab makes total sense. I've cancelled the current run, since it's useless to spend one more day on CI provided we can't merge it anyway. Feel free to rebase and ping me when you think it's ready.

carlocab · 2020-12-14T14:39:21Z

Sure. Happy to do that. One thing I'm still unsure about is the remaining SHA256 mismatch. Should I include the commit that fixes that with my next push? Or should I leave it out and fix it when upstream responds?

fxcoudert · 2020-12-14T14:40:21Z

Re silicon please leave it out, we can't merge until it's confirmed, and I don't want it to block this PR

carlocab · 2020-12-14T14:44:02Z

Done. Should be ready now, unless you want to wait for another round of tests.

fxcoudert · 2020-12-14T15:14:08Z

@carlocab we'll wait for the tests, so we can check nothing new is broken, and also importantly so we get the bottles built by CI

carlocab · 2020-12-14T15:15:20Z

Sure. Will ping you when tests are done.

I've broken off silicon into a separate PR: #66903

Confirmed by repo owner: Findomain/Findomain#121 (comment)

This is a local workaround that should be removed at the next version bump. See https://framagit.org/simgrid/simgrid/-/issues/59

See Homebrew#66555

carlocab · 2020-12-16T05:14:12Z

Ping @fxcoudert

deno seems to have gotten broken again, but it's getting a version bump here: #66920

My fix for pike didn't quite take, but that's because the CI node couldn't fetch the source. (Expired SSL cert.) I hope it's not a problem that it didn't get bottled here...

There also appear to have been some spurious failures, like

==> brew audit findomain --online --git --skip-style
==> FAILED
Error: GitHub Bad credentials:HOMEBREW_GITHUB_API_TOKEN may be invalid or expired; check:

If all if this is fine I think this one's ready.

fxcoudert · 2020-12-16T08:01:43Z

@carlocab thanks, merging

This was modified but not bottled in: Homebrew#66285 Homebrew@1ee9564 We also add a Debian mirror, as the homepage currently has an expired SSL certificate.

This was modified but not bottled in: #66285 1ee9564 We also add a Debian mirror, as the homepage currently has an expired SSL certificate. Closes #67020. Signed-off-by: FX Coudert <[email protected]>

carlocab mentioned this pull request Dec 5, 2020

rust 1.48 #65286

Closed

This comment has been minimized.

Sign in to view

sorawee mentioned this pull request Dec 9, 2020

brew install rust --HEAD fails #66548

Closed

4 tasks

carlocab force-pushed the rust-tests branch from e8265cb to a17ba7f Compare December 10, 2020 03:27

BrewTestBot added the python Python use is a significant feature of the PR or issue label Dec 10, 2020

This was referenced Dec 11, 2020

v0.3.3 tarball sha256 change? cmyr/cargo-instruments#27

Closed

v2.1.4 tarball sha256 change? Findomain/Findomain#121

Closed

v0.4.0 tarball sha256 change? Aloxaf/silicon#141

Closed

carlocab mentioned this pull request Dec 11, 2020

rust-1.47 contains mismatched tools #63202

Closed

4 tasks

This was referenced Dec 11, 2020

deno 1.6.0 #66482

Closed

Homebrew CI Test Failure: "thread 'main' panicked" jimmycuadra/ktmpl#5

Closed

carlocab force-pushed the rust-tests branch from a17ba7f to 71d3af8 Compare December 11, 2020 17:55

carlocab changed the title ~~Rust 1.48 revision bumps~~ Rust 1.48 Dec 11, 2020

chenrui333 changed the title ~~Rust 1.48~~ rust 1.48 Dec 12, 2020

carlocab force-pushed the rust-tests branch from 71d3af8 to 4af1b7a Compare December 13, 2020 12:24

carlocab mentioned this pull request Dec 13, 2020

pike: workarounds for building on Xcode 12 #66555

Closed

carlocab force-pushed the rust-tests branch from 4af1b7a to 6b892c2 Compare December 13, 2020 13:59

carlocab mentioned this pull request Dec 13, 2020

cargo-instruments 0.3.4 #66872

Closed

carlocab force-pushed the rust-tests branch from 6b892c2 to b406ff5 Compare December 14, 2020 14:43

toxeus and others added 4 commits December 14, 2020 15:23

rust 1.48

dc2499a

findomain: update url + homepage

3e2a980

Confirmed by repo owner: Findomain/Findomain#121 (comment)

simgrid: fix build failure

40d9483

This is a local workaround that should be removed at the next version bump. See https://framagit.org/simgrid/simgrid/-/issues/59

pike: remove librsvg dependency

d0566df

See Homebrew#66555

carlocab force-pushed the rust-tests branch from b406ff5 to d0566df Compare December 14, 2020 15:25

deno: revision bump (rust 1.48)

a7406a4

carlocab mentioned this pull request Dec 14, 2020

deno 1.7.0 #66920

Closed

fxcoudert closed this in 3267cf4 Dec 16, 2020

carlocab deleted the rust-tests branch December 16, 2020 12:58

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Dec 16, 2020

pike: rebottle

94349c4

This was modified but not bottled in: Homebrew#66285 Homebrew@1ee9564 We also add a Debian mirror, as the homepage currently has an expired SSL certificate.

This was referenced Dec 16, 2020

pike: rebottle #67020

Closed

brew install deno failed denoland/deno#8801

Closed

BrewTestBot added the outdated PR was locked due to age label Jan 16, 2021

Homebrew locked as resolved and limited conversation to collaborators Jan 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rust 1.48 #66285

rust 1.48 #66285

carlocab commented Dec 5, 2020 •

edited

Loading

This comment has been minimized.

carlocab commented Dec 11, 2020 •

edited

Loading

carlocab commented Dec 11, 2020 •

edited

Loading

carlocab commented Dec 11, 2020 •

edited

Loading

carlocab commented Dec 11, 2020 •

edited

Loading

carlocab commented Dec 11, 2020 •

edited

Loading

carlocab commented Dec 11, 2020

carlocab commented Dec 14, 2020 •

edited

Loading

fxcoudert commented Dec 14, 2020

carlocab commented Dec 14, 2020

fxcoudert commented Dec 14, 2020

carlocab commented Dec 14, 2020 •

edited

Loading

fxcoudert commented Dec 14, 2020

carlocab commented Dec 14, 2020

carlocab commented Dec 16, 2020

fxcoudert commented Dec 16, 2020

rust 1.48 #66285

rust 1.48 #66285

Conversation

carlocab commented Dec 5, 2020 • edited Loading

10.14

10.15

11.0

This comment has been minimized.

carlocab commented Dec 11, 2020 • edited Loading

carlocab commented Dec 11, 2020 • edited Loading

carlocab commented Dec 11, 2020 • edited Loading

carlocab commented Dec 11, 2020 • edited Loading

carlocab commented Dec 11, 2020 • edited Loading

carlocab commented Dec 11, 2020

carlocab commented Dec 14, 2020 • edited Loading

fxcoudert commented Dec 14, 2020

carlocab commented Dec 14, 2020

fxcoudert commented Dec 14, 2020

carlocab commented Dec 14, 2020 • edited Loading

fxcoudert commented Dec 14, 2020

carlocab commented Dec 14, 2020

carlocab commented Dec 16, 2020

fxcoudert commented Dec 16, 2020

carlocab commented Dec 5, 2020 •

edited

Loading

carlocab commented Dec 11, 2020 •

edited

Loading

carlocab commented Dec 11, 2020 •

edited

Loading

carlocab commented Dec 11, 2020 •

edited

Loading

carlocab commented Dec 11, 2020 •

edited

Loading

carlocab commented Dec 11, 2020 •

edited

Loading

carlocab commented Dec 14, 2020 •

edited

Loading

carlocab commented Dec 14, 2020 •

edited

Loading