Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno 1.6.0 #66482

Closed
Closed

Conversation

crunchtime-ali
Copy link
Contributor

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Dec 8, 2020
@chenrui333
Copy link
Member

    Finished release [optimized] target(s) in 83m 03s
  Installing /usr/local/Cellar/deno/1.6.0/bin/deno
   Installed package `deno v1.6.0 (/private/tmp/deno-20201208-18034-ywy33s/deno/cli)` (executable `deno`)
warning: be sure to add `/usr/local/Cellar/deno/1.6.0/bin` to your PATH to be able to run the installed binaries
Error: Failure while executing; `/usr/local/Cellar/deno/1.6.0/bin/deno completions zsh` exited with 101. Here's the output:

@chenrui333 chenrui333 added the build failure CI fails while building the software label Dec 8, 2020
@carlocab
Copy link
Member

This appears to have been fixed here: denoland/deno#8718

Any chance this can be turned into a patch? It would help me a great deal with #66285

@carlocab carlocab mentioned this pull request Dec 11, 2020
5 tasks
@carlocab
Copy link
Member

I think this patch should work:

# Remove at next version bump. Check that new release includes:
# https://github.com/denoland/deno/pull/8718
patch do
  url "https://github.com/denoland/deno/compare/df87bf1..e52ac4f.patch?full_index=1"
  sha256 "af8fb4b041bb8656187c9e0b2d270decc82a4a29dd8abd5269a02730810018ed"
end

@crunchtime-ali
Copy link
Contributor Author

I think this patch should work:

# Remove at next version bump. Check that new release includes:
# https://github.com/denoland/deno/pull/8718
patch do
  url "https://github.com/denoland/deno/compare/df87bf1..e52ac4f.patch?full_index=1"
  sha256 "af8fb4b041bb8656187c9e0b2d270decc82a4a29dd8abd5269a02730810018ed"
end

I just applied this patch. Thank you for the hint.

@chenrui333 chenrui333 added CI-requeued PR has been re-added to the queue and removed build failure CI fails while building the software labels Dec 13, 2020
@carlocab
Copy link
Member

Ok, guess the patch didn't apply cleanly. Sorry about that!

@gromgit
Copy link
Contributor

gromgit commented Dec 14, 2020

Try this instead:

patch do
  url "https://github.com/denoland/deno/commit/cea42bec3272a8020f1d94afcf1a4cd7e3985553.patch?full_index=1"
  sha256 "640ece7aab8e7486ea0ec4bfd29ac7e980822a57d12123e802d022bdc7bbaed7"
end

@chenrui333
Copy link
Member

Thanks @crunchtime-ali!

@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@chenrui333 chenrui333 removed the CI-requeued PR has been re-added to the queue label Dec 14, 2020
@carlocab carlocab mentioned this pull request Dec 17, 2020
5 tasks
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 14, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants