Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

godep: disable #66808

Closed
wants to merge 3 commits into from
Closed

godep: disable #66808

wants to merge 3 commits into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 12, 2020 •
edited
Loading

  1. Disable godep
  2. Remove godep dependencies from cig and the_platinum_searcher

godep has been deprecated for a while now. It's time that it's disabled, as no Homebrew formulae depend on it anymore.

This should also help fix some CI failures in #66355.

I think #47627 is also related.

@carlocab
godep: disable
c133ea2 
godep has been deprecated for some time now, and no more Homebrew
formulae depend on it. It's time to disable it.
@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Dec 12, 2020
@carlocab carlocab mentioned this pull request Dec 12, 2020
Closed
@Loyalsoldier
Copy link
Contributor

BTW, can I delete my forked repos of those two if upstreams don't merge that two PRs?

@carlocab
Copy link
Member Author

@Loyalsoldier

Er, I'm not sure, since I'm not sure what happens to the commits we're basing the patches of these formulae on when you delete your fork.

If you wish to delete your forks, then I think the safest course of action would be to migrate your patches first to https://github.com/Homebrew/formula-patches so that they can hosted there, with the patches here updated to refer to those instead. Then it would be fine for you to delete your fork.

@Loyalsoldier
Copy link
Contributor

@Loyalsoldier

Er, I'm not sure, since I'm not sure what happens to the commits we're basing the patches of these formulae on when you delete your fork.

If you wish to delete your forks, then I think the safest course of action would be to migrate your patches first to https://github.com/Homebrew/formula-patches so that they can hosted there, with the patches here updated to refer to those instead. Then it would be fine for you to delete your fork.

Got it.

@carlocab

This comment has been minimized.

Sign in to view
@chenrui333 chenrui333 added the formula disabled Formula disabled label Dec 12, 2020
@carlocab carlocab requested a review from dawidd6 December 13, 2020 12:36
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@carlocab carlocab deleted the godep-deprecate branch December 13, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dawidd6 dawidd6 dawidd6 approved these changes

Assignees
No one assigned
Labels
formula disabled Formula disabled go Go use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carlocab @Loyalsoldier @BrewTestBot @dawidd6 @chenrui333