Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh-completions: remove bottle :unneeded #75982

Closed
wants to merge 1 commit into from

Conversation

Amar1729
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

See #75943.

@BrewTestBot BrewTestBot added the missing license Formula has a missing license which should be added label Apr 26, 2021
@nandahkrishna nandahkrishna added CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. do not merge labels Apr 26, 2021
@Amar1729
Copy link
Contributor Author

Amar1729 commented Apr 26, 2021

sha256sum *tar.gz

91c622e31c02e1405484ff6f8ebd891174d0160bddd8e9a6ab46eb9b71898a95  bottles/zsh-completions--0.32.0.arm64_big_sur.bottle.tar.gz
8de3c33a6695339766ba8446637e4a406105dbd86c7aa3d5da8d20496fc07a03  bottles/zsh-completions--0.32.0.big_sur.bottle.tar.gz
8de3c33a6695339766ba8446637e4a406105dbd86c7aa3d5da8d20496fc07a03  bottles/zsh-completions--0.32.0.catalina.bottle.tar.gz
1ee78c06fbe812cbf39b715c90a4c953a74af5422ff80dac83fb923db034f747  bottles/zsh-completions--0.32.0.mojave.bottle.tar.gz
> diff -r zsh-completions-arm64 zsh-completions-big-sur

diff -r zsh-completions-arm64/0.32.0/share/zsh-completions/_ghc zsh-completions-big-sur/0.32.0/share/zsh-completions/_ghc
178c178
<                 ${^=LD_LIBRARY_PATH:-/usr/lib /usr/local/lib}/lib*.(a|so*)(:t:fr:s/lib//) \
---
>                 ${^=LD_LIBRARY_PATH:-/usr/lib @@HOMEBREW_PREFIX@@/lib}/lib*.(a|so*)(:t:fr:s/lib//) \

Is keg_relocate.rb supposed to change out paths, or is that a mistake? Original source has /usr/local/lib

@Amar1729
Copy link
Contributor Author

After rebuild:

> sha256sum *.tar.gz

0d433bc55d208e9cc66d74017a6a5d5ae1a768e51d984ab2e25a4dcf1a01899e  zsh-completions--0.32.0.arm64_big_sur.bottle.tar.gz
b717660dece7fdbcd772f6d331679518a580e020cff879c58e9cc8a3b9c51ab5  zsh-completions--0.32.0.big_sur.bottle.tar.gz
b717660dece7fdbcd772f6d331679518a580e020cff879c58e9cc8a3b9c51ab5  zsh-completions--0.32.0.catalina.bottle.tar.gz
b717660dece7fdbcd772f6d331679518a580e020cff879c58e9cc8a3b9c51ab5  zsh-completions--0.32.0.mojave.bottle.tar.gz

Still the same difference as above between the big sur arm/x86 bottles.

@Amar1729 Amar1729 force-pushed the bottle/zsh-completions branch from 67aa13a to 50049e5 Compare April 28, 2021 02:46
@Amar1729
Copy link
Contributor Author

After rebuild / relocation fix, hashes match:

> sha256sum *.tar.gz

a70978173faa1ce102d7a1fe224c4fcc90ef56f414f42781c109d4b4883bcaa9  zsh-completions--0.32.0.arm64_big_sur.bottle.tar.gz
a70978173faa1ce102d7a1fe224c4fcc90ef56f414f42781c109d4b4883bcaa9  zsh-completions--0.32.0.big_sur.bottle.tar.gz
a70978173faa1ce102d7a1fe224c4fcc90ef56f414f42781c109d4b4883bcaa9  zsh-completions--0.32.0.catalina.bottle.tar.gz
a70978173faa1ce102d7a1fe224c4fcc90ef56f414f42781c109d4b4883bcaa9  zsh-completions--0.32.0.mojave.bottle.tar.gz

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Amar1729!

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@chenrui333 chenrui333 added the bottle-up-everything Make every formula bottled label May 3, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
@Amar1729 Amar1729 deleted the bottle/zsh-completions branch September 11, 2023 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. missing license Formula has a missing license which should be added outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants