Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottle all bottle :unneeded #75943

Closed
14 tasks done
MikeMcQuaid opened this issue Apr 26, 2021 · 8 comments
Closed
14 tasks done

Bottle all bottle :unneeded #75943

MikeMcQuaid opened this issue Apr 26, 2021 · 8 comments
Labels
help wanted Task(s) needing PRs from the community or maintainers outdated PR was locked due to age

Comments

@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Apr 26, 2021

Everything that's bottle :unneeded has got to go! should be bottled. This can be done by creating a pull request removing the bottle :unneeded line and allowing the bottles to be committed as usual.

For bonus points, verify the checksums of all generated artefacts are the same and attempt to fix them up (or CC me and I'll give it a go).


[cho-m] Tracking the remaining:

@MikeMcQuaid MikeMcQuaid added the help wanted Task(s) needing PRs from the community or maintainers label Apr 26, 2021
nandahkrishna added a commit to nandahkrishna/homebrew-core that referenced this issue Apr 26, 2021
@Moisan Moisan mentioned this issue Apr 27, 2021
BrewTestBot pushed a commit that referenced this issue Apr 27, 2021
See #75943.

Closes #75944.

Signed-off-by: Carlo Cabrera <[email protected]>
Signed-off-by: BrewTestBot <[email protected]>
nandahkrishna added a commit to nandahkrishna/homebrew-core that referenced this issue Apr 28, 2021
nandahkrishna added a commit to nandahkrishna/homebrew-core that referenced this issue Apr 28, 2021
BrewTestBot pushed a commit that referenced this issue Jun 27, 2021
BrewTestBot pushed a commit that referenced this issue Jun 27, 2021
BrewTestBot pushed a commit that referenced this issue Jun 27, 2021
BrewTestBot pushed a commit that referenced this issue Jun 27, 2021
BrewTestBot pushed a commit that referenced this issue Jun 27, 2021
#75943

Closes #79997.

Signed-off-by: Michael Cho <[email protected]>
Signed-off-by: Nanda H Krishna <[email protected]>
Signed-off-by: BrewTestBot <[email protected]>
cho-m pushed a commit to cho-m/homebrew-core that referenced this issue Jun 27, 2021
BrewTestBot pushed a commit that referenced this issue Jun 28, 2021
#75943

Closes #80145.

Signed-off-by: Carlo Cabrera <[email protected]>
Signed-off-by: BrewTestBot <[email protected]>
carlocab added a commit to carlocab/homebrew-core that referenced this issue Jun 28, 2021
This formula does not work, because the zipballs it needs to download
are no longer available.

Also, add `openjdk` dependency.

Homebrew#75943

Co-authored-by: Carlo Cabrera <[email protected]>
nandahkrishna pushed a commit that referenced this issue Jun 28, 2021
This formula does not work, because the zipballs it needs to download
are no longer available.

Also, add `openjdk` dependency.

#75943

Co-authored-by: Carlo Cabrera <[email protected]>

Co-authored-by: Mike McQuaid <[email protected]>
@MikeMcQuaid
Copy link
Member Author

Done, great work and thanks for the help everyone ❤️

kraktus added a commit to kraktus/brew that referenced this issue Jul 25, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Task(s) needing PRs from the community or maintainers outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants