solr 8.9.0

[alebcay]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[carlocab]

Checksums:

❯ sha256sum *.tar.gz
d649e575245d38a65c8de89c2fa7ec005b0010ffb3a49956509eefac1177e4d7  solr--8.9.0.arm64_big_sur.bottle.tar.gz
d93cc0531969c84a896115e6e3adc859374676405cb5bf3a14508714844b470c  solr--8.9.0.big_sur.bottle.tar.gz
d93cc0531969c84a896115e6e3adc859374676405cb5bf3a14508714844b470c  solr--8.9.0.catalina.bottle.tar.gz
d93cc0531969c84a896115e6e3adc859374676405cb5bf3a14508714844b470c  solr--8.9.0.mojave.bottle.tar.gz

The diff:

❯ diffoscope *.arm64_big_sur.bottle*tar.gz *.big_sur.bottle*tar.gz
--- solr--8.9.0.arm64_big_sur.bottle.tar.gz
+++ solr--8.9.0.big_sur.bottle.tar.gz
│   --- solr--8.9.0.arm64_big_sur.bottle.tar
├── +++ solr--8.9.0.big_sur.bottle.tar
│ ├── file list
│ │ @@ -218,15 +218,15 @@
│ │  -rw-r--r--   0        0        0   247297 2021-06-10 21:54:44.000000 solr/8.9.0/dist/test-framework/lib/randomizedtesting-runner-2.7.2.jar
│ │  drwxr-xr-x   0        0        0        0 2021-06-10 21:54:44.000000 solr/8.9.0/dist/test-framework/lucene-libs/
│ │  -rw-r--r--   0        0        0 10964192 2021-06-10 21:54:44.000000 solr/8.9.0/dist/test-framework/lucene-libs/lucene-test-framework-8.9.0.jar
│ │  -rw-r--r--   0        0        0      683 2021-06-10 21:54:44.000000 solr/8.9.0/homebrew.mxcl.solr.plist
│ │  drwxr-xr-x   0        0        0        0 2021-06-10 21:54:44.000000 solr/8.9.0/libexec/
│ │  -rwxr-xr-x   0        0        0     1508 2021-06-10 21:54:44.000000 solr/8.9.0/libexec/oom_solr.sh
│ │  -rwxr-xr-x   0        0        0     8209 2021-06-10 21:54:44.000000 solr/8.9.0/libexec/post
│ │ --rwxr-xr-x   0        0        0    85965 2021-06-10 21:54:44.000000 solr/8.9.0/libexec/solr
│ │ +-rwxr-xr-x   0        0        0    85983 2021-06-10 21:54:44.000000 solr/8.9.0/libexec/solr
│ │  drwxr-xr-x   0        0        0        0 2021-06-10 21:54:44.000000 solr/8.9.0/server/
│ │  -rw-r--r--   0        0        0     3933 2021-06-10 21:54:44.000000 solr/8.9.0/server/README.txt
│ │  drwxr-xr-x   0        0        0        0 2021-06-10 21:54:44.000000 solr/8.9.0/server/contexts/
│ │  -rw-r--r--   0        0        0      474 2021-06-10 21:54:44.000000 solr/8.9.0/server/contexts/solr-jetty-context.xml
│ │  drwxr-xr-x   0        0        0        0 2021-06-10 21:54:44.000000 solr/8.9.0/server/etc/
│ │  -rw-r--r--   0        0        0     2686 2021-06-10 21:54:44.000000 solr/8.9.0/server/etc/jetty-http.xml
│ │  -rw-r--r--   0        0        0     3698 2021-06-10 21:54:44.000000 solr/8.9.0/server/etc/jetty-https.xml
│ ├── solr/8.9.0/libexec/solr
│ │ @@ -21,15 +21,15 @@
│ │  # to passing command-line options, this script looks for an include
│ │  # file named solr.in.sh to set environment variables. Specifically,
│ │  # the following locations are searched in this order:
│ │  #
│ │  # ./
│ │  # $HOME/.solr.in.sh
│ │  # /usr/share/solr
│ │ -# /usr/local/share/solr
│ │ +# @@HOMEBREW_PREFIX@@/share/solr
│ │  # /var/solr/
│ │  # /opt/solr
│ │  #
│ │  # Another option is to specify the full path to the include file in the
│ │  # environment. For example:
│ │  #
│ │  #   $ SOLR_INCLUDE=/path/to/solr.in.sh solr start
│ │ @@ -79,15 +79,15 @@
│ │
│ │  # If an include wasn't specified in the environment, then search for one...
│ │  if [ -z "$SOLR_INCLUDE" ]; then
│ │    # Locations (in order) to use when searching for an include file.
│ │    for include in "`dirname "$0"`/solr.in.sh" \
│ │                 "$HOME/.solr.in.sh" \
│ │                 /usr/share/solr/solr.in.sh \
│ │ -               /usr/local/share/solr/solr.in.sh \
│ │ +               @@HOMEBREW_PREFIX@@/share/solr/solr.in.sh \
│ │                 /etc/default/solr.in.sh \
│ │                 /opt/solr/solr.in.sh; do
│ │      if [ -r "$include" ]; then
│ │          SOLR_INCLUDE="$include"
│ │          . "$include"
│ │          break
│ │      fi

I think we maybe want to change that /usr/local into an /opt/homebrew?

Especially since we do ship a solr/solr.in.sh in pkgshare.

[MikeMcQuaid]

I think we maybe want to change that /usr/local into an /opt/homebrew?

Especially since we do ship a solr/solr.in.sh in pkgshare.

Makes sense to me 👍🏻

[BrewTestBot]

@MikeMcQuaid has triggered a merge.